Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privatize from_layout_js functions. #8549

Merged
merged 1 commit into from Nov 17, 2015
Merged

Privatize from_layout_js functions. #8549

merged 1 commit into from Nov 17, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 16, 2015

Review on Reviewable
@highfive
Copy link

highfive commented Nov 16, 2015

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
@jdm
Copy link
Member

jdm commented Nov 16, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2015

📌 Commit 298a6b3 has been approved by jdm
@pcwalton
Copy link
Contributor

pcwalton commented Nov 16, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2015

📌 Commit 298a6b3 has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2015

⌛ Testing commit 298a6b3 with merge e4a0272...
bors-servo added a commit that referenced this pull request Nov 16, 2015
@bors-servo
Auto merge of #8549 - Ms2ger:privatize, r=pcwalton
e4a0272 
Privatize from_layout_js functions.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8549)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2015

💔 Test failed - linux-rel
@eefriedman
Copy link
Contributor

eefriedman commented Nov 16, 2015

@bors-servo retry #8487
@bors-servo
Copy link
Contributor

bors-servo commented Nov 17, 2015

⌛ Testing commit 298a6b3 with merge 0f3dd2d...
bors-servo added a commit that referenced this pull request Nov 17, 2015
@bors-servo
Auto merge of #8549 - Ms2ger:privatize, r=pcwalton
0f3dd2d 
Privatize from_layout_js functions.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8549)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 17, 2015

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Nov 17, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 17, 2015

⌛ Testing commit 298a6b3 with merge 213e3ba...
bors-servo added a commit that referenced this pull request Nov 17, 2015
@bors-servo
Auto merge of #8549 - Ms2ger:privatize, r=pcwalton
213e3ba 
Privatize from_layout_js functions.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8549)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 17, 2015

💔 Test failed - linux-rel
@eefriedman
Copy link
Contributor

eefriedman commented Nov 17, 2015

@bors-servo retry #8487
@bors-servo
Copy link
Contributor

bors-servo commented Nov 17, 2015

⌛ Testing commit 298a6b3 with merge 2b9ed57...
bors-servo added a commit that referenced this pull request Nov 17, 2015
@bors-servo
Auto merge of #8549 - Ms2ger:privatize, r=pcwalton
2b9ed57 
Privatize from_layout_js functions.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8549)
<!-- Reviewable:end -->
@Ms2ger Ms2ger closed this Nov 17, 2015
@Ms2ger Ms2ger reopened this Nov 17, 2015
@Ms2ger
Privatize from_layout_js functions.
Loading status checks…
3fb16cc
@Ms2ger Ms2ger force-pushed the Ms2ger:privatize branch from 298a6b3 to 3fb16cc Nov 17, 2015
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 17, 2015

@bors-servo r=pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Nov 17, 2015

📌 Commit 3fb16cc has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Nov 17, 2015

⌛ Testing commit 3fb16cc with merge cedaac8...
bors-servo added a commit that referenced this pull request Nov 17, 2015
@bors-servo
Auto merge of #8549 - Ms2ger:privatize, r=pcwalton
Loading status checks…
cedaac8 
Privatize from_layout_js functions.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8549)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 17, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 3fb16cc into servo:master Nov 17, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:privatize branch Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Ms2ger @highfive @jdm @bors-servo @pcwalton @eefriedman
You can’t perform that action at this time.