Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInclude transform changes in list that cause incremental reflows. #8559
Conversation
highfive
commented
Nov 17, 2015
|
|
|
r? @pcwalton |
|
Missing testcase? |
|
We don't have a way to reliably test incremental layout bugs at the moment. |
|
Hmm, this looks pretty suboptimal (and not what other browsers do). We shouldn't be reflowing when transforms change. In fact, that's much of the purpose of CSS transforms existing… |
|
The problem is that the value of the transform variable affects whether it needs a layer - which is only calculated during reflow. I'll update the PR to only trigger a reflow when those special case changes of transform occur. |
|
@pcwalton Updated to include that change - good catch :) |
|
@bors-servo: r+ |
|
|
|
|
Include transform changes in list that cause incremental reflows. Also ensure that 3d translations get layers. Fixes #8329. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8559) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
|
|
|
|
glennw commentedNov 17, 2015
Also ensure that 3d translations get layers.
Fixes #8329.