Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more CSS module tests #8565

Merged
merged 2 commits into from Jan 5, 2016
Merged

Enable more CSS module tests #8565

merged 2 commits into from Jan 5, 2016

Conversation

@gsnedders
Copy link
Contributor

gsnedders commented Nov 17, 2015

As noted, this excludes Fonts, on the assumption #8374 will land first. This should get us testing every property we support, I think.

Review on Reviewable
@highfive
Copy link

highfive commented Nov 17, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @glennw (or someone else) soon.
@gsnedders
Copy link
Contributor Author

gsnedders commented Nov 17, 2015

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Nov 17, 2015

⌛ Trying commit 6a840da with merge 45bde73...
bors-servo added a commit that referenced this pull request Nov 17, 2015
@bors-servo
Auto merge of #8565 - gsnedders:more_css_module_tests, r=<try>
45bde73 
Enable more CSS module tests

As noted, this excludes Fonts, on the assumption #8374 will land first. This should get us testing every property we support, I think.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 17, 2015

💔 Test failed - mac-rel-css
@gsnedders
Copy link
Contributor Author

gsnedders commented Nov 17, 2015 

Tests with unexpected results:
  ▶ Unexpected subtest result in /css-transitions-1_dev/html/properties-value-001.htm:
  └ PASS [expected FAIL] height length(pt) / values

  ▶ Unexpected subtest result in /css-transitions-1_dev/html/properties-value-inherit-003.htm:
  └ PASS [expected FAIL] border-right-width length-em(em) / values

  ▶ Unexpected subtest result in /css-transitions-1_dev/html/properties-value-inherit-003.htm:
  └ PASS [expected FAIL] padding-bottom length-em(em) / values

  ▶ Unexpected subtest result in /css-transitions-1_dev/html/properties-value-inherit-003.htm:
  └ PASS [expected FAIL] margin-bottom length-em(em) / values

  ▶ Unexpected subtest result in /css-transitions-1_dev/html/properties-value-inherit-003.htm:
  └ PASS [expected FAIL] width length-em(em) / values

  ▶ Unexpected subtest result in /css-transitions-1_dev/html/properties-value-inherit-003.htm:
  │ FAIL [expected PASS] border-left-width length-em(em) / values
  │   → assert_not_equals: initial and target values may not match got disallowed value "22px"
  │ FAIL [expected PASS] outline-offset length-em(em) / values
  │   → assert_not_equals: initial and target values may not match got disallowed value "22px"
  │ 
  │ .cases.values.start@http://web-platform.test:8000/css-transitions-1_dev/html/properties-value-inherit-003.htm:70:29
  │ runLoop/</</<@http://web-platform.test:8000/css-transitions-1_dev/html/support/runParallelAsyncHarness.js:110:22
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1226:20
  │ runLoop/</<@http://web-platform.test:8000/css-transitions-1_dev/html/support/runParallelAsyncHarness.js:109:17
  │ runLoop/<@http://web-platform.test:8000/css-transitions-1_dev/html/support/runParallelAsyncHarness.js:108:13
  └ runLoop@http://web-platform.test:8000/css-transitions-1_dev/html/support/runParallelAsyncHarness.js:107:9

  ▶ Unexpected subtest result in /css-transitions-1_dev/html/properties-value-inherit-002.htm:
  └ PASS [expected FAIL] padding-bottom length(cm) / values

  ▶ Unexpected subtest result in /css-transitions-1_dev/html/transitions-animatable-properties-01.htm:
  └ NOTRUN [expected PASS] font-size intermediate

  ▶ PASS [expected CRASH] /css-transforms-1_dev/html/svg-translate-006.htm
@gsnedders
Copy link
Contributor Author

gsnedders commented Nov 17, 2015

Bah. A lot of these transitions tests seem to be random, and that transforms test is an intermittent crash.
@gsnedders
Copy link
Contributor Author

gsnedders commented Nov 17, 2015

linux-rel had a bunch of the transitions tests time out, too…
@gsnedders
Copy link
Contributor Author

gsnedders commented Nov 17, 2015

Conclusion on IRC is to disable the random tests.
@gsnedders gsnedders force-pushed the gsnedders:more_css_module_tests branch from 6a840da to 0446ba9 Dec 1, 2015
@highfive highfive removed the S-tests-failed label Dec 1, 2015
@gsnedders gsnedders mentioned this pull request Dec 1, 2015
Closed
@gsnedders
Copy link
Contributor Author

gsnedders commented Dec 1, 2015

@bors-servo try
bors-servo added a commit that referenced this pull request Dec 1, 2015
@bors-servo
Auto merge of #8565 - gsnedders:more_css_module_tests, r=<try>
f9f3665 
Enable more CSS module tests

As noted, this excludes Fonts, on the assumption #8374 will land first. This should get us testing every property we support, I think.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8565)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2015

⌛ Trying commit 725ca24 with merge f9f3665...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2015

💔 Test failed - mac-rel-css
@gsnedders
Copy link
Contributor Author

gsnedders commented Dec 1, 2015

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2015

⌛ Trying commit eb0a336 with merge f1a2b84...
bors-servo added a commit that referenced this pull request Dec 1, 2015
@bors-servo
Auto merge of #8565 - gsnedders:more_css_module_tests, r=<try>
f1a2b84 
Enable more CSS module tests

As noted, this excludes Fonts, on the assumption #8374 will land first. This should get us testing every property we support, I think.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8565)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2015

💔 Test failed - linux-rel
@SimonSapin
Copy link
Member

SimonSapin commented Dec 3, 2015 

  ▶ TIMEOUT [expected OK] /css-transitions-1_dev/html/properties-value-inherit-001.htm

(Lots of TIMEOUT and NOTRUN subtests)

  ▶ FAIL [expected PASS] /css-flexbox-1_dev/html/css-flexbox-column-reverse.htm
  └   → /css-flexbox-1_dev/html/css-flexbox-column-reverse.htm b2d841c70185698b294c6b5ab6ba7135ddffaeab
/css-flexbox-1_dev/html/reference/css-flexbox-column-ref.htm 4c1c7da7e7b20df6ec20c20364127cf1cdf82ca6
Testing b2d841c70185698b294c6b5ab6ba7135ddffaeab == 4c1c7da7e7b20df6ec20c20364127cf1cdf82ca6

  ▶ FAIL [expected PASS] /css-text-3_dev/html/word-break-normal-ar-000.htm
  └   → /css-text-3_dev/html/word-break-normal-ar-000.htm 781fa943d05a90d3d52c49ca38832ebe0f17e99b
/css-text-3_dev/html/reference/word-break-normal-ar-ref-000.htm 45fe8dc5205843b9238fda6e911d894a0b3335ea
Testing 781fa943d05a90d3d52c49ca38832ebe0f17e99b == 45fe8dc5205843b9238fda6e911d894a0b3335ea
@gsnedders
Copy link
Contributor Author

gsnedders commented Dec 3, 2015

Yeah, I saw. Never had those timeout locally. sighs I fear we'll just have to disable all the transitions tests?
@nox
Copy link
Member

nox commented Jan 4, 2016

And reviewed beforehand, I guess.
gsnedders added 2 commits Nov 9, 2015
@gsnedders
Enable CSS tests for all modules we partially support.
756d745 
(Except Fonts, on the assumption #8374 will land first.)
@gsnedders
Reorder CSS tests to be in alphabetical order.
Loading status checks…
5845a60
@gsnedders gsnedders force-pushed the gsnedders:more_css_module_tests branch from 74ea7ce to 5845a60 Jan 4, 2016
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jan 4, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 4, 2016

📌 Commit 5845a60 has been approved by larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented Jan 4, 2016

⌛ Testing commit 5845a60 with merge f34e3ca...
bors-servo added a commit that referenced this pull request Jan 4, 2016
@bors-servo
Auto merge of #8565 - gsnedders:more_css_module_tests, r=larsbergstrom
f34e3ca 
Enable more CSS module tests

As noted, this excludes Fonts, on the assumption #8374 will land first. This should get us testing every property we support, I think.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8565)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 4, 2016

💔 Test failed - linux-rel
@gsnedders
Copy link
Contributor Author

gsnedders commented Jan 4, 2016

That failure is #9106. Do we want to retry or not?
@nox
Copy link
Member

nox commented Jan 5, 2016

@bors-servo retry #9106
@bors-servo
Copy link
Contributor

bors-servo commented Jan 5, 2016

⌛ Testing commit 5845a60 with merge e94a530...
bors-servo added a commit that referenced this pull request Jan 5, 2016
@bors-servo
Auto merge of #8565 - gsnedders:more_css_module_tests, r=larsbergstrom
Loading status checks…
e94a530 
Enable more CSS module tests

As noted, this excludes Fonts, on the assumption #8374 will land first. This should get us testing every property we support, I think.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8565)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 5, 2016

💔 Test failed - mac-rel-wpt
@gsnedders
Copy link
Contributor Author

gsnedders commented Jan 5, 2016

@bors-servo retry #4701 (not really a great report but the only thing we have for that failure)
@bors-servo
Copy link
Contributor

bors-servo commented Jan 5, 2016

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 5, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 5845a60 into servo:master Jan 5, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Jan 5, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@gsnedders @highfive @bors-servo @SimonSapin @frewsxcv @nox @larsbergstrom
You can’t perform that action at this time.