Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test-wpt run with RUST_BACKTRACE=1 by default #8194 #8590

Merged

Conversation

@nxnfufunezn
Copy link
Contributor

nxnfufunezn commented Nov 18, 2015

Fixes #8194

Review on Reviewable

@nxnfufunezn
Copy link
Contributor Author

nxnfufunezn commented Nov 18, 2015

r? @jdm

@jdm
Copy link
Member

jdm commented Nov 18, 2015

I'm not convinced that this actually works, since we don't do anything with the env variable. We should use os.environment like the line above it, instead.

@nxnfufunezn nxnfufunezn force-pushed the nxnfufunezn:_run_test-wpt_with_RUST_BACKTRACE branch from 98b9cfd to c7fab07 Nov 18, 2015
@jdm
Copy link
Member

jdm commented Nov 18, 2015

@bors-servo: r+
Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2015

📌 Commit c7fab07 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2015

Testing commit c7fab07 with merge cbd8f3a...

bors-servo added a commit that referenced this pull request Nov 18, 2015
…r=jdm

Make test-wpt run with RUST_BACKTRACE=1 by default #8194

Fixes #8194

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8590)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2015

💔 Test failed - linux-rel

@frewsxcv
Copy link
Member

frewsxcv commented Nov 19, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2015

Testing commit c7fab07 with merge 1dd4c08...

bors-servo added a commit that referenced this pull request Nov 19, 2015
…r=jdm

Make test-wpt run with RUST_BACKTRACE=1 by default #8194

Fixes #8194

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8590)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2015

@bors-servo bors-servo merged commit c7fab07 into servo:master Nov 19, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.