Split paint task messages from ScriptMsg

[g-k]

Refs: #8592

[jdm]

@KiChjang Want to take a swing at reviewing this?

[KiChjang]

Sure!

[KiChjang]

Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.

---

components/compositing/constellation.rs, line 628 [r1] (raw file):
We might want to have some ways of distinguishing between Failure messages that are fired from the script. Two ways I can think of: pass an additional string parameter to handle_failure_msg or move the debug!macro up here and to the branch handling ScriptMsg::Failure above.

---

Comments from the review on Reviewable.io

[KiChjang]

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from the review on Reviewable.io

[bors-servo]

☔ The latest upstream changes (presumably #8599) made this pull request unmergeable. Please resolve the merge conflicts.

[KiChjang]

I see that you have made a new commit to address the previous issues @g-k , but you'll need to rebase this branch onto master before it can be merged, and also squash your commits. See https://github.com/servo/servo/wiki/Github-&-Critic-PR-handling-101 for a detailed explanation (ignore the part about critic, it's an old review system which we currently do not use anymore).

Essentially what needs to happen is:

git remote add mozilla git@github.com:servo/servo.git
git fetch mozilla
git rebase mozilla/master

This rebases your branch onto servo's master. Now, onto squashing commits:

git rebase -i HEAD~2

Delete the second line's "pick" and replace it with "f". Finally force-push your branch:

git push -f

[g-k]

Thanks @KiChjang! I rebased and autosquashed but have a build failing with

error: the trait `serde::ser::Serialize` is not implemented for the type `std::sync::mpsc::Sender<msg::constellation_msg::PaintMsg>`

and

error: mismatched types:
 expected `msg::constellation_msg::ConstellationChan<msg::constellation_msg::PaintMsg>`,
    found `std::sync::mpsc::Sender<msg::constellation_msg::PaintMsg>`
(expected struct `msg::constellation_msg::ConstellationChan`,
    found struct `std::sync::mpsc::Sender`) [E0308]

errors. Should painter_chan have type msg::constellation_msg::ConstellationChan<msg::constellation_msg::PaintMsg> or std::sync::mpsc::Sender<msg::constellation_msg::PaintMsg>?

[eefriedman]

@g-k https://github.com/servo/servo/pull/8598/files#diff-f4724c64bbfdec08f0ff93b3fc660d96R75 .

[g-k]

Thanks @eefriedman! don't know how I missed that.

[g-k]

Rebased.

[KiChjang]

Almost there! Once you address the comments, ask @jdm to r+.

---

Reviewed 4 of 4 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

components/compositing/constellation.rs, line 285 [r2] (raw file):
nit: Do we still need this comment here?

---

Comments from the review on Reviewable.io

[jdm]

@bors-servo: delegate=KiChjang

[bors-servo]

✌️ @KiChjang can now approve this pull request

[g-k]

Review status: 3 of 4 files reviewed at latest revision, 1 unresolved discussion.

---

components/compositing/constellation.rs, line 285 [r2] (raw file):
I don't think so. Removed!

---

Comments from the review on Reviewable.io

[KiChjang]

@bors-servo r+

---

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from the review on Reviewable.io

[bors-servo]

📌 Commit 7668fd0 has been approved by KiChjang

[bors-servo]

⌛ Testing commit 7668fd0 with merge 5e7306b...

[bors-servo]

💔 Test failed - linux-rel

[jdm]

@bors-servo: retry

• #8676

[bors-servo]

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...

[bors-servo]

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

[KiChjang]

\o/