Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content_type to metadata in file_loader #8609

Merged
merged 1 commit into from Nov 24, 2015
Merged

Add content_type to metadata in file_loader #8609

merged 1 commit into from Nov 24, 2015

Conversation

@KiChjang
Copy link
Member

KiChjang commented Nov 19, 2015

Fixes #4212.

Review on Reviewable
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 24, 2015

r? @jdm

(Looks like the new dep is MIT-licensed.)
@frewsxcv
Copy link
Member

frewsxcv commented Nov 24, 2015

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2015

⌛ Trying commit ec9f111 with merge a6e113c...
bors-servo added a commit that referenced this pull request Nov 24, 2015
@bors-servo
Auto merge of #8609 - KiChjang:file-loader-headers, r=<try>
a6e113c 
Add content_type to metadata in file_loader

Fixes #4212.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8609)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2015

💔 Test failed - gonk
@frewsxcv
Copy link
Member

frewsxcv commented Nov 24, 2015

You need to update the gonk lockfile
@jdm
Copy link
Member

jdm commented Nov 24, 2015

@bors-servo: delegate+
This is fine to merge when the lockfiles are updated.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2015

✌️ @KiChjang can now approve this pull request
@KiChjang KiChjang force-pushed the KiChjang:file-loader-headers branch from ec9f111 to b7f6eda Nov 24, 2015
@KiChjang
Copy link
Member Author

KiChjang commented Nov 24, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2015

📌 Commit b7f6eda has been approved by KiChjang
@KiChjang
Copy link
Member Author

KiChjang commented Nov 24, 2015

@bors-servo r-
@KiChjang KiChjang force-pushed the KiChjang:file-loader-headers branch from b7f6eda to 1a515c6 Nov 24, 2015
@KiChjang
Copy link
Member Author

KiChjang commented Nov 24, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2015

📌 Commit 1a515c6 has been approved by KiChjang
@jdm
Copy link
Member

jdm commented Nov 24, 2015

Looks like the CEF lockfile is still not updated. It should be enough to do ./mach cargo-update -p net.
@KiChjang KiChjang force-pushed the KiChjang:file-loader-headers branch from 1a515c6 to af705a6 Nov 24, 2015
@KiChjang
Copy link
Member Author

KiChjang commented Nov 24, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2015

📌 Commit af705a6 has been approved by KiChjang
@KiChjang
Add content_type to metadata in file_loader
Loading status checks…
af705a6
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2015

⌛ Testing commit af705a6 with merge ed6a3f5...
bors-servo added a commit that referenced this pull request Nov 24, 2015
@bors-servo
Auto merge of #8609 - KiChjang:file-loader-headers, r=KiChjang
Loading status checks…
ed6a3f5 
Add content_type to metadata in file_loader

Fixes #4212.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8609)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit af705a6 into servo:master Nov 24, 2015
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
homu Test successful
Details
@KiChjang KiChjang deleted the KiChjang:file-loader-headers branch Nov 24, 2015
@bors-servo bors-servo mentioned this pull request Nov 24, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@KiChjang @Ms2ger @frewsxcv @bors-servo @jdm @highfive
You can’t perform that action at this time.