Add test to constellation to avoid writing reftest image if there are pending frames. #8612

glennw · 2015-11-20T02:20:47Z

This changes several tests that contain <iframe></iframe> from FAIL to TIMEOUT. This is correct
since there is a bug that prevents these iframes from ever rendering.

may genuinely be fixed by this change.~~~

<!-- Reviewable:start -->

[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8612)

<!-- Reviewable:end -->

glennw · 2015-11-20T02:20:53Z

r? @jdm

glennw · 2015-11-20T02:22:07Z

@jdm I didn't do any timing, but it felt like this make the wpt tests take a lot longer to execute. Unfortunately it's necessary so there's not much we can do about that anyway.

glennw · 2015-11-20T02:43:51Z

@bors-servo try

bors-servo · 2015-11-20T02:43:53Z

⌛ Trying commit 89a9fab with merge 8909053...


        Auto merge of #8612 - glennw:pending-frames, r=<try>

Add test to constellation to avoid writing reftest image if there are pending frames. This changes several tests that contain <iframe></iframe> from FAIL to TIMEOUT. This is correct since there is a bug that prevents these iframes from ever rendering. There are also a few previous FAILs that changed to OK. These may be intermittents or they may genuinely be fixed by this change.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8612)

bors-servo · 2015-11-20T03:13:30Z

💔 Test failed - mac-rel-css

glennw · 2015-11-20T03:21:38Z

@jdm I expect this will also fix some of our remaining intermittent failures.

glennw · 2015-11-20T03:22:07Z

@bors-servo try

bors-servo · 2015-11-20T03:22:09Z

⌛ Trying commit 1007fdc with merge 02c8871...


        Auto merge of #8612 - glennw:pending-frames, r=<try>

Add test to constellation to avoid writing reftest image if there are pending frames. This changes several tests that contain <iframe></iframe> from FAIL to TIMEOUT. This is correct since there is a bug that prevents these iframes from ever rendering. ~~~There are also a few previous FAILs that changed to OK. These may be intermittents or they may genuinely be fixed by this change.~~~  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8612)

bors-servo · 2015-11-20T03:48:05Z

💔 Test failed - linux-rel

jdm · 2015-11-20T05:30:30Z

That panic is #8614.

jdm · 2015-11-20T05:34:20Z

@bors-servo: r+
Good find!

bors-servo · 2015-11-20T05:34:21Z

📌 Commit 1007fdc has been approved by jdm

glennw · 2015-11-20T19:12:00Z

@bors-servo try

glennw · 2015-11-20T19:12:29Z

@bors-servo try

larsbergstrom · 2015-11-20T19:20:35Z

@bors-servo r=jdm try- retry

bors-servo · 2015-11-20T19:20:37Z

📌 Commit 1007fdc has been approved by jdm


        Auto merge of #8612 - glennw:pending-frames, r=jdm

Add test to constellation to avoid writing reftest image if there are pending frames. This changes several tests that contain <iframe></iframe> from FAIL to TIMEOUT. This is correct since there is a bug that prevents these iframes from ever rendering. ~~~There are also a few previous FAILs that changed to OK. These may be intermittents or they may genuinely be fixed by this change.~~~  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8612)

bors-servo · 2015-12-16T22:52:14Z

💔 Test failed - mac-rel-css

jdm · 2015-12-16T22:56:44Z

This design makes me worried about cases where we don't properly trigger reflow. I wonder if the following would work better:

the compositor assumes each frame is pending
when the compositor reaches the state where it needs to know if a frame is ready:
- if the frame is marked pending, it sends an async message to the script thread and updates the frame state to awaiting reply
- if the frame is marked awaiting reply, the compositor is not ready to take a screenshot
when the script thread receives the message, it sends an async message to the compositor based on the document ready state and the presence of reftest-wait
when the compositor receives the message, it updates the state of the relevant frame based on the contents of the message (ie. the frame is no longer marked awaiting reply)

jdm · 2015-12-16T23:31:18Z

-S-awaiting-review +S-needs-code-changes

Reviewed 1 of 1 files at r5.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

components/script/dom/window.rs, line 1004 [r5] (raw file):
Let's have a comment that explains this block.

Comments from the review on Reviewable.io

glennw · 2015-12-17T01:12:17Z

@bors-servo try

bors-servo · 2015-12-17T01:12:19Z

⌛ Trying commit b387633 with merge bd2a00a...


        Auto merge of #8612 - glennw:pending-frames, r=<try>

Add test to constellation to avoid writing reftest image if there are pending frames. This changes several tests that contain <iframe></iframe> from FAIL to TIMEOUT. This is correct since there is a bug that prevents these iframes from ever rendering. ~~~There are also a few previous FAILs that changed to OK. These may be intermittents or they may genuinely be fixed by this change.~~~  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8612)

jdm · 2015-12-17T01:22:23Z

Good catch! I have no more comments here; this is ready to merge if it passes tests repeatably :)
-S-awaiting-review

Reviewed 1 of 1 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

bors-servo · 2015-12-17T02:28:46Z

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt


        Add test to constellation to avoid writing reftest image if there are…

… pending frames. Also change when pipelines become active. This makes the constellation activate a pipeline as the current frame when it is ready to do initial reflow, rather than when it is ready to paint. This fixes a number of intermittent failures that could previously occur if an iframe was not visible - which would mean it was never moved from a pending frame in the constellation to an active frame. (It happens that webrender exposes these intermittents as permanent failures).

glennw · 2015-12-17T02:31:55Z

@jdm Try build succeeded, squashed down to 1 commit.

Ms2ger · 2015-12-17T10:49:13Z

@bors-servo r=jdm

bors-servo · 2015-12-17T10:49:14Z

📌 Commit b670430 has been approved by jdm

bors-servo · 2015-12-17T10:49:16Z

⌛ Testing commit b670430 with merge c6ae32a...


        Auto merge of #8612 - glennw:pending-frames, r=jdm

Add test to constellation to avoid writing reftest image if there are pending frames. This changes several tests that contain <iframe></iframe> from FAIL to TIMEOUT. This is correct since there is a bug that prevents these iframes from ever rendering. ~~~There are also a few previous FAILs that changed to OK. These may be intermittents or they may genuinely be fixed by this change.~~~  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8612)

bors-servo · 2015-12-17T12:05:35Z

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

highfive added the S-awaiting-review label Nov 20, 2015

highfive assigned jdm Nov 20, 2015

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 20, 2015

glennw force-pushed the glennw:pending-frames branch from 89a9fab to 1007fdc Nov 20, 2015

highfive removed the S-tests-failed label Nov 20, 2015

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 20, 2015

highfive added S-awaiting-merge and removed S-awaiting-review S-tests-failed labels Nov 20, 2015

highfive added the S-tests-failed label Dec 16, 2015

jdm added S-needs-code-changes and removed S-awaiting-review labels Dec 16, 2015

highfive added S-awaiting-review and removed S-tests-failed S-needs-code-changes labels Dec 17, 2015

jdm removed the S-awaiting-review label Dec 17, 2015

glennw force-pushed the glennw:pending-frames branch from b387633 to b670430 Dec 17, 2015

highfive added the S-awaiting-review label Dec 17, 2015

highfive added S-awaiting-merge and removed S-awaiting-review labels Dec 17, 2015

Ms2ger mentioned this pull request Dec 17, 2015

Move PaintMsg enum to gfx_traits #8844 #9007

Closed

bors-servo mentioned this pull request Dec 17, 2015

Separate script and layout messages, issue #8843 #8958

Merged

glennw deleted the glennw:pending-frames branch Dec 12, 2016

servo / servo

Add test to constellation to avoid writing reftest image if there are pending frames. #8612

Add test to constellation to avoid writing reftest image if there are pending frames. #8612

glennw commented Nov 20, 2015

glennw commented Nov 20, 2015

glennw commented Nov 20, 2015

glennw commented Nov 20, 2015

bors-servo commented Nov 20, 2015

bors-servo commented Nov 20, 2015

glennw commented Nov 20, 2015

glennw commented Nov 20, 2015

bors-servo commented Nov 20, 2015

bors-servo commented Nov 20, 2015

jdm commented Nov 20, 2015

jdm commented Nov 20, 2015

bors-servo commented Nov 20, 2015

glennw commented Nov 20, 2015

glennw commented Nov 20, 2015

larsbergstrom commented Nov 20, 2015

bors-servo commented Nov 20, 2015

bors-servo commented Dec 16, 2015

jdm commented Dec 16, 2015

jdm commented Dec 16, 2015

glennw commented Dec 17, 2015

bors-servo commented Dec 17, 2015

jdm commented Dec 17, 2015

bors-servo commented Dec 17, 2015

glennw commented Dec 17, 2015

Ms2ger commented Dec 17, 2015

bors-servo commented Dec 17, 2015

bors-servo commented Dec 17, 2015

bors-servo commented Dec 17, 2015

servo / servo

Join GitHub today

Add test to constellation to avoid writing reftest image if there are pending frames. #8612

Add test to constellation to avoid writing reftest image if there are pending frames. #8612

Conversation

glennw commented Nov 20, 2015

glennw commented Nov 20, 2015

glennw commented Nov 20, 2015

glennw commented Nov 20, 2015

bors-servo commented Nov 20, 2015

bors-servo commented Nov 20, 2015

glennw commented Nov 20, 2015

glennw commented Nov 20, 2015

bors-servo commented Nov 20, 2015

bors-servo commented Nov 20, 2015

jdm commented Nov 20, 2015

jdm commented Nov 20, 2015

bors-servo commented Nov 20, 2015

glennw commented Nov 20, 2015

glennw commented Nov 20, 2015

larsbergstrom commented Nov 20, 2015

bors-servo commented Nov 20, 2015

bors-servo commented Dec 16, 2015

jdm commented Dec 16, 2015

jdm commented Dec 16, 2015

glennw commented Dec 17, 2015

bors-servo commented Dec 17, 2015

jdm commented Dec 17, 2015

bors-servo commented Dec 17, 2015

glennw commented Dec 17, 2015

Ms2ger commented Dec 17, 2015

bors-servo commented Dec 17, 2015

bors-servo commented Dec 17, 2015

bors-servo commented Dec 17, 2015