Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser API: implement iframe.reload() #8618

Merged
merged 1 commit into from Dec 17, 2015
Merged

Browser API: implement iframe.reload() #8618

merged 1 commit into from Dec 17, 2015

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Nov 20, 2015

fixes #8575

The implementation is naive, and doesn't support the hardreload parameter.
And for the test, I'm not sure how else I can test the reload.

Review on Reviewable
@paulrouget paulrouget force-pushed the paulrouget:reload branch from a0cd50d to 1f509d0 Nov 20, 2015
@jdm
Copy link
Member

jdm commented Nov 20, 2015

Is there a spec for how this is supposed to behave? Is it supposed to reload the current contents of the iframe, or reload the url specified by the src attribute?
@paulrouget
Copy link
Contributor Author

paulrouget commented Nov 20, 2015

It's supposed to reload the current contents of the iframe… and now I realize that this code reloads the src attribute :)
@jdm jdm self-assigned this Nov 20, 2015
@paulrouget
Browser API: implement iframe.reload()
Loading status checks…
2a86f9d
@paulrouget paulrouget force-pushed the paulrouget:reload branch from 1f509d0 to 2a86f9d Dec 8, 2015
@jdm
Copy link
Member

jdm commented Dec 17, 2015

@bors-servo: r+
Changes look good to me. Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2015

📌 Commit 2a86f9d has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2015

⌛ Testing commit 2a86f9d with merge 9570b51...
bors-servo added a commit that referenced this pull request Dec 17, 2015
@bors-servo
Auto merge of #8618 - paulrouget:reload, r=jdm
Loading status checks…
9570b51 
Browser API: implement iframe.reload()

fixes #8575

The implementation is naive, and doesn't support the `hardreload` parameter.
And for the test, I'm not sure how else I can test the reload.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8618)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2015

⛄ The build was interrupted to prioritize another pull request.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2015

⚡ Previous build results for gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-wpt are reusable. Rebuilding only android, mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2015

⛄ The build was interrupted to prioritize another pull request.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2015

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-wpt are reusable. Rebuilding only mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 2a86f9d into servo:master Dec 17, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Dec 17, 2015
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Browser API: implement iframe.reload()
4 participants
@paulrouget @jdm @bors-servo @highfive
You can’t perform that action at this time.