Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wptrunner for some old-style reftests. #8619

Merged
merged 8 commits into from Nov 20, 2015
Merged

Use wptrunner for some old-style reftests. #8619

merged 8 commits into from Nov 20, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 20, 2015

Review on Reviewable
Ms2ger added 8 commits Nov 20, 2015
@Ms2ger
Move list_style_position_a.html to wpt reftests.
6a2cbfc
@Ms2ger
Move list_style_type_a.html to wpt reftests.
872334a
@Ms2ger
Move margin_a.html to wpt reftests.
1a55b4a
@Ms2ger
Move marker_block_direction_placement_a.html to wpt reftests.
07d1f3f
@Ms2ger
Move noteq_attr_exists_selector.html to wpt reftests.
6a862fc
@Ms2ger
Move octicons_a.html to wpt reftests.
d6a7794
@Ms2ger
Move ol_japanese_iroha_a.html and ol_japanese_iroha_bullet_styles.htm…
22656dc 
…l to wpt reftests.
@Ms2ger
Move overflow_auto.html, overflow_scroll.html and overflow_simple_a.h…
Loading status checks…
068a584 
…tml to wpt reftests.
@frewsxcv frewsxcv self-assigned this Nov 20, 2015
@frewsxcv
Copy link
Member

frewsxcv commented Nov 20, 2015

@bors-servo r+

Reviewed 8 of 8 files at r1, 6 of 6 files at r2, 6 of 6 files at r3, 6 of 6 files at r4, 5 of 5 files at r5, 10 of 10 files at r6, 12 of 12 files at r7, 10 of 10 files at r8.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2015

📌 Commit 068a584 has been approved by frewsxcv
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2015

⌛ Testing commit 068a584 with merge cb443b4...
bors-servo added a commit that referenced this pull request Nov 20, 2015
@bors-servo
Auto merge of #8619 - Ms2ger:test-ref, r=frewsxcv
Loading status checks…
cb443b4 
Use wptrunner for some old-style reftests.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8619)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2015

💔 Test failed - linux-rel
@frewsxcv
Copy link
Member

frewsxcv commented Nov 20, 2015

@bors-servo retry #8614
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2015

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2015

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Nov 20, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2015

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 068a584 into servo:master Nov 20, 2015
3 checks passed
3 checks passed
code-review/reviewable Review complete: all files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frewsxcv frewsxcv

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Ms2ger @frewsxcv @bors-servo @jdm @SimonSapin @highfive
You can’t perform that action at this time.