Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement 'url!(..)' macro #8622

Merged
merged 1 commit into from Nov 21, 2015
Merged

Implement 'url!(..)' macro #8622

merged 1 commit into from Nov 21, 2015

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv mentioned this pull request Nov 20, 2015
Closed
@SimonSapin
Copy link
Member

@bors-servo r+

Thanks!

@bors-servo
Copy link
Contributor

📌 Commit bf97f8f has been approved by SimonSapin

@frewsxcv
Copy link
Member Author

@bors-servo r-

Tidy...

@frewsxcv
Copy link
Member Author

@bors-servo r=SimonSapin

@bors-servo
Copy link
Contributor

📌 Commit e36bdb1 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

⌛ Testing commit e36bdb1 with merge 85308a5...

bors-servo pushed a commit that referenced this pull request Nov 20, 2015
Auto merge of #8622 - frewsxcv:url-plugin, r=SimonSapin
85308a5 
Implement 'url!(..)' macro

servo/rust-url#136

servo/rust-url#137

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8622)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - gonk

@jdm
Copy link
Member

jdm commented Nov 20, 2015

Lockfiles need updating.

@frewsxcv
Copy link
Member Author

Lockfiles for cef and gonk have been added

@jdm
Copy link
Member

jdm commented Nov 20, 2015

@bors-servo: r=SimonSapin

@bors-servo
Copy link
Contributor

📌 Commit 120c0d1 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

⌛ Testing commit 120c0d1 with merge 155a9d0...

bors-servo pushed a commit that referenced this pull request Nov 21, 2015
Auto merge of #8622 - frewsxcv:url-plugin, r=SimonSapin
155a9d0 
Implement 'url!(..)' macro

servo/rust-url#136

servo/rust-url#137

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8622)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-dev

@eefriedman
Copy link
Contributor 

/home/servo/buildbot/slave/linux-dev/build/tests/unit/plugin/url_plugin.rs:8:21: 8:23 error: relative URL without a base
/home/servo/buildbot/slave/linux-dev/build/tests/unit/plugin/url_plugin.rs:8                url!("").to_string());
                                                                                                 ^~
/home/servo/buildbot/slave/linux-dev/build/tests/unit/plugin/url_plugin.rs:8:16: 8:24 note: in this expansion of url! (defined in /home/servo/buildbot/slave/linux-dev/build/tests/unit/plugin/lib.rs)
/home/servo/buildbot/slave/linux-dev/build/tests/unit/plugin/url_plugin.rs:7:5: 8:38 note: in this expansion of assert_eq! (defined in <std macros>)

@frewsxcv
Copy link
Member Author

Ah yeah. I reverted that usage locally but apparently forgot to commit it. Without my computer right now so I'll have to fix it later.

@frewsxcv
Copy link
Member Author

Removed it in the latest force push

@jdm
Copy link
Member

jdm commented Nov 21, 2015

@bors-servo: r=SimonSapin

@bors-servo
Copy link
Contributor

📌 Commit f34da41 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

⌛ Testing commit f34da41 with merge ea690a2...

bors-servo pushed a commit that referenced this pull request Nov 21, 2015
Auto merge of #8622 - frewsxcv:url-plugin, r=SimonSapin
ea690a2 
Implement 'url!(..)' macro

servo/rust-url#136

servo/rust-url#137

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8622)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit f34da41 into servo:master Nov 21, 2015
@bors-servo bors-servo mentioned this pull request Nov 21, 2015
Closed
@frewsxcv frewsxcv deleted the url-plugin branch November 21, 2015 19:54
@SimonSapin SimonSapin mentioned this pull request Nov 25, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@frewsxcv @SimonSapin @bors-servo @jdm @eefriedman @highfive