Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'url!(..)' macro #8622

Merged
merged 1 commit into from Nov 21, 2015
Merged

Implement 'url!(..)' macro #8622

merged 1 commit into from Nov 21, 2015
+346 −128

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Nov 20, 2015

servo/rust-url#136

servo/rust-url#137

Review on Reviewable
@frewsxcv frewsxcv mentioned this pull request Nov 20, 2015
Closed
@SimonSapin
Copy link
Member

SimonSapin commented Nov 20, 2015

@bors-servo r+

Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2015

📌 Commit bf97f8f has been approved by SimonSapin
@frewsxcv
Copy link
Member Author

frewsxcv commented Nov 20, 2015

@bors-servo r-

Tidy...
@frewsxcv frewsxcv force-pushed the frewsxcv:url-plugin branch from bf97f8f to e36bdb1 Nov 20, 2015
@frewsxcv
Copy link
Member Author

frewsxcv commented Nov 20, 2015

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2015

📌 Commit e36bdb1 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2015

⌛ Testing commit e36bdb1 with merge 85308a5...
bors-servo added a commit that referenced this pull request Nov 20, 2015
@bors-servo
Auto merge of #8622 - frewsxcv:url-plugin, r=SimonSapin
85308a5 
Implement 'url!(..)' macro

servo/rust-url#136

servo/rust-url#137

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8622)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2015

💔 Test failed - gonk
@jdm
Copy link
Member

jdm commented Nov 20, 2015

Lockfiles need updating.
@frewsxcv frewsxcv force-pushed the frewsxcv:url-plugin branch from e36bdb1 to 120c0d1 Nov 20, 2015
@frewsxcv
Copy link
Member Author

frewsxcv commented Nov 20, 2015

Lockfiles for cef and gonk have been added
@jdm
Copy link
Member

jdm commented Nov 20, 2015

@bors-servo: r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2015

📌 Commit 120c0d1 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2015

⌛ Testing commit 120c0d1 with merge 155a9d0...
bors-servo added a commit that referenced this pull request Nov 21, 2015
@bors-servo
Auto merge of #8622 - frewsxcv:url-plugin, r=SimonSapin
155a9d0 
Implement 'url!(..)' macro

servo/rust-url#136

servo/rust-url#137

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8622)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2015

💔 Test failed - linux-dev
@eefriedman
Copy link
Contributor

eefriedman commented Nov 21, 2015 

/home/servo/buildbot/slave/linux-dev/build/tests/unit/plugin/url_plugin.rs:8:21: 8:23 error: relative URL without a base
/home/servo/buildbot/slave/linux-dev/build/tests/unit/plugin/url_plugin.rs:8                url!("").to_string());
                                                                                                 ^~
/home/servo/buildbot/slave/linux-dev/build/tests/unit/plugin/url_plugin.rs:8:16: 8:24 note: in this expansion of url! (defined in /home/servo/buildbot/slave/linux-dev/build/tests/unit/plugin/lib.rs)
/home/servo/buildbot/slave/linux-dev/build/tests/unit/plugin/url_plugin.rs:7:5: 8:38 note: in this expansion of assert_eq! (defined in <std macros>)
@frewsxcv
Copy link
Member Author

frewsxcv commented Nov 21, 2015

Ah yeah. I reverted that usage locally but apparently forgot to commit it. Without my computer right now so I'll have to fix it later.
@frewsxcv
Implement 'url!(..)' macro
Loading status checks…
f34da41 
servo/rust-url#136

servo/rust-url#137
@frewsxcv frewsxcv force-pushed the frewsxcv:url-plugin branch from 120c0d1 to f34da41 Nov 21, 2015
@frewsxcv
Copy link
Member Author

frewsxcv commented Nov 21, 2015

Removed it in the latest force push
@jdm
Copy link
Member

jdm commented Nov 21, 2015

@bors-servo: r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2015

📌 Commit f34da41 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2015

⌛ Testing commit f34da41 with merge ea690a2...
bors-servo added a commit that referenced this pull request Nov 21, 2015
@bors-servo
Auto merge of #8622 - frewsxcv:url-plugin, r=SimonSapin
Loading status checks…
ea690a2 
Implement 'url!(..)' macro

servo/rust-url#136

servo/rust-url#137

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8622)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit f34da41 into servo:master Nov 21, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Nov 21, 2015
Closed
@frewsxcv frewsxcv deleted the frewsxcv:url-plugin branch Nov 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@frewsxcv @SimonSapin @bors-servo @jdm @eefriedman @highfive
You can’t perform that action at this time.