Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update string cache #8667

Merged
merged 1 commit into from Nov 25, 2015
Merged

Update string cache #8667

merged 1 commit into from Nov 25, 2015

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Nov 24, 2015

Updated string_cache to 0.2, and updated the dependencies that depend on string_cache.
Removed references to string_cache_plugin.
Import atom! and ns! from string_cache.
Replaced ns!("") by ns!().
Replaced ns!(XML) and co by ns!(xml) and co.
Replaced Atom::from_slice by Atom::from.
Replaced atom.as_slice() by &*atom.

r? @SimonSapin

Review on Reviewable
@highfive
Copy link

highfive commented Nov 24, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
@SimonSapin
Copy link
Member

SimonSapin commented Nov 24, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2015

📌 Commit 59edd90 has been approved by SimonSapin
@SimonSapin
Copy link
Member

SimonSapin commented Nov 24, 2015

@bors-servo r-

+S-needs-squash
@asajeffrey asajeffrey force-pushed the asajeffrey:update-string-cache branch from 59edd90 to d666e49 Nov 24, 2015
@SimonSapin
Copy link
Member

SimonSapin commented Nov 24, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2015

📌 Commit d666e49 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

⌛ Testing commit d666e49 with merge 47729e4...
bors-servo added a commit that referenced this pull request Nov 25, 2015
@bors-servo
Auto merge of #8667 - asajeffrey:update-string-cache, r=SimonSapin
47729e4 
Update string cache

Updated string_cache to 0.2, and updated the dependencies that depend on string_cache.
Removed references to string_cache_plugin.
Import atom! and ns! from string_cache.
Replaced ns!("") by ns!().
Replaced ns!(XML) and co by ns!(xml) and co.
Replaced Atom::from_slice by Atom::from.
Replaced atom.as_slice() by &*atom.

r? @SimonSapin

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8667)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

💔 Test failed - mac-dev-ref-unit
@asajeffrey
Copy link
Member Author

asajeffrey commented Nov 25, 2015

Failing to build on MacOS. The OS-specific files weren't updated, oops. I'll fix this tomorrow.
@asajeffrey asajeffrey force-pushed the asajeffrey:update-string-cache branch from d666e49 to 003cb1e Nov 25, 2015
@SimonSapin
Copy link
Member

SimonSapin commented Nov 25, 2015

@bors-servo r+

Reviewed 66 of 66 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

📌 Commit 003cb1e has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

⌛ Testing commit 003cb1e with merge beda038...
bors-servo added a commit that referenced this pull request Nov 25, 2015
@bors-servo
Auto merge of #8667 - asajeffrey:update-string-cache, r=SimonSapin
beda038 
Update string cache

Updated string_cache to 0.2, and updated the dependencies that depend on string_cache.
Removed references to string_cache_plugin.
Import atom! and ns! from string_cache.
Replaced ns!("") by ns!().
Replaced ns!(XML) and co by ns!(xml) and co.
Replaced Atom::from_slice by Atom::from.
Replaced atom.as_slice() by &*atom.

r? @SimonSapin

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8667)
<!-- Reviewable:end -->
@asajeffrey
Copy link
Member Author

asajeffrey commented Nov 25, 2015

Edited components/gfx/platform/macos/font_template.rs, hopefully that's the only breaking MacOS-specific file.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

💔 Test failed - mac-dev-ref-unit
@asajeffrey
Update string_cache to 0.2.
Loading status checks…
3dec6ed 
Updated string_cache, html5ever, xml5ever and selectors in Cargo.toml files and Cargo.lock.
Removed references to string_cache_plugin.
Import atom! and ns! from string_cache.
Replaced ns!("") by ns!().
Replaced ns!(XML) and co by ns!(xml) and co.
Replaced atom!(foo) by atom!("foo").
Replaced Atom::from_slice by Atom::from.
Replaced atom.as_slice() by &*atom.
@asajeffrey asajeffrey force-pushed the asajeffrey:update-string-cache branch from 003cb1e to 3dec6ed Nov 25, 2015
@SimonSapin
Copy link
Member

SimonSapin commented Nov 25, 2015

@bors-servo r+

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

📌 Commit 3dec6ed has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

⌛ Testing commit 3dec6ed with merge 188fa93...
bors-servo added a commit that referenced this pull request Nov 25, 2015
@bors-servo
Auto merge of #8667 - asajeffrey:update-string-cache, r=SimonSapin
Loading status checks…
188fa93 
Update string cache

Updated string_cache to 0.2, and updated the dependencies that depend on string_cache.
Removed references to string_cache_plugin.
Import atom! and ns! from string_cache.
Replaced ns!("") by ns!().
Replaced ns!(XML) and co by ns!(xml) and co.
Replaced Atom::from_slice by Atom::from.
Replaced atom.as_slice() by &*atom.

r? @SimonSapin

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8667)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 3dec6ed into servo:master Nov 25, 2015
3 checks passed
3 checks passed
code-review/reviewable Review complete: all files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Nov 25, 2015
Merged
Closed
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@asajeffrey @highfive @SimonSapin @bors-servo
You can’t perform that action at this time.