Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clip rect for iframes in hit testing code #8671

Merged
merged 2 commits into from Nov 25, 2015
Merged

Fix clip rect for iframes in hit testing code #8671

merged 2 commits into from Nov 25, 2015

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Nov 25, 2015

Fixes #8080 r? @mrobinson

Review on Reviewable
mbrubeck added 2 commits Nov 17, 2015
@mbrubeck @paulrouget
Fix clip rect for iframes in hit testing code
a61989e 
Fixes #8080
@mbrubeck @paulrouget
Convert from client to page coords in script
Loading status checks…
7b79949
@paulrouget
Copy link
Contributor Author

paulrouget commented Nov 25, 2015

This is a rebase of #8557
@paulrouget paulrouget mentioned this pull request Nov 25, 2015
Closed
components/compositing/compositor.rs

let clipped_layer_bounds = match clip_rect.intersection(&layer_bounds) {
// Total offset from parent coordinates to this layer's coordinates.
// FIXME: This offset is incorrect for fixed-position layers.

This comment has been minimized.

Sign in to view
Copy link
@pcwalton

pcwalton Nov 25, 2015

Contributor

Could we get an issue on file for this? It shouldn't be hard to fix.

This comment has been minimized.

Sign in to view
Copy link
@paulrouget

paulrouget Nov 25, 2015

Author Contributor

done: #8672
@pcwalton
Copy link
Contributor

pcwalton commented Nov 25, 2015

This looks good to me.
@paulrouget paulrouget mentioned this pull request Nov 25, 2015
Closed
@glennw
Copy link
Member

glennw commented Nov 25, 2015

@bors-servo r=pcwalton
1 similar comment
@glennw
Copy link
Member

glennw commented Nov 25, 2015

@bors-servo r=pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

📌 Commit 7b79949 has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

⌛ Testing commit 7b79949 with merge e8e7c3e...
bors-servo added a commit that referenced this pull request Nov 25, 2015
@bors-servo
Auto merge of #8671 - paulrouget:iframe-hit-test, r=pcwalton
e8e7c3e 
Fix clip rect for iframes in hit testing code

Fixes #8080 r? @mrobinson

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8671)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

💔 Test failed - linux-rel
@paulrouget
Copy link
Contributor Author

paulrouget commented Nov 25, 2015 


Tests with unexpected results:
  ▶ TIMEOUT [expected FAIL] /css-flexbox-1_dev/html/flexbox-basic-iframe-vert-001.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ was ready to save, resetting ready_to_save_state
  └ Shutting down the Constellation after generating an output file or exit flag specified

  ▶ TIMEOUT [expected FAIL] /css-flexbox-1_dev/html/flexbox-basic-iframe-horiz-001.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ was ready to save, resetting ready_to_save_state
  └ Shutting down the Constellation after generating an output file or exit flag specified

I can't reproduce locally (osx):

./mach test-css --release  tests/wpt/css-tests/css-flexbox-1_dev/html/flexbox-basic-iframe-horiz-001.htm

Not sure what to do next
@jdm
Copy link
Member

jdm commented Nov 25, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

⌛ Testing commit 7b79949 with merge fd3421b...
bors-servo added a commit that referenced this pull request Nov 25, 2015
@bors-servo
Auto merge of #8671 - paulrouget:iframe-hit-test, r=pcwalton
fd3421b 
Fix clip rect for iframes in hit testing code

Fixes #8080 r? @mrobinson

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8671)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

💔 Test failed - linux-rel
@paulrouget
Copy link
Contributor Author

paulrouget commented Nov 25, 2015

Looks like a different issue this time?

  ▶ TIMEOUT [expected PASS] /_mozilla/css/canvas_over_area.html
  │ 
  │ updating composition_request (NewFrameTree)
  │ not ready to composite: NotReadyToPaintImage(JustNotifiedConstellation)
  │ not ready to composite: NotReadyToPaintImage(WaitingOnConstellation)
  │ not ready to composite: NotReadyToPaintImage(WaitingOnConstellation)
  │ not ready to composite: NotReadyToPaintImage(WaitingOnConstellation)
  │ not ready to composite: NotReadyToPaintImage(WaitingOnConstellation)
[…]
@jdm
Copy link
Member

jdm commented Nov 25, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

⌛ Testing commit 7b79949 with merge 6bbd654...
bors-servo added a commit that referenced this pull request Nov 25, 2015
@bors-servo
Auto merge of #8671 - paulrouget:iframe-hit-test, r=pcwalton
6bbd654 
Fix clip rect for iframes in hit testing code

Fixes #8080 r? @mrobinson

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8671)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Nov 25, 2015

@bors-servo: retry

  • sorry, playing with builders interfered
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Nov 25, 2015

@bors-servo: retry

  • more builder investgiations
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Nov 25, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

⌛ Testing commit 7b79949 with merge 8efc954...
bors-servo added a commit that referenced this pull request Nov 25, 2015
@bors-servo
Auto merge of #8671 - paulrouget:iframe-hit-test, r=pcwalton
Loading status checks…
8efc954 
Fix clip rect for iframes in hit testing code

Fixes #8080 r? @mrobinson

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8671)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 25, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo mentioned this pull request Nov 25, 2015
Closed
@bors-servo bors-servo merged commit 7b79949 into servo:master Nov 25, 2015
2 of 3 checks passed
2 of 3 checks passed
code-review/reviewable Review in progress: 0 of 3 files reviewed, 1 unresolved discussion
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@paulrouget @pcwalton @glennw @bors-servo @jdm @highfive @mbrubeck
You can’t perform that action at this time.