Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some compositing cleanup. #8688

Merged
merged 3 commits into from Nov 28, 2015
Merged

Some compositing cleanup. #8688

merged 3 commits into from Nov 28, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 26, 2015

Review on Reviewable
Ms2ger added 3 commits Nov 26, 2015
@Ms2ger
Remove unused PrivilegedPipelineContent::constellation_chan.
6eff8d6
@Ms2ger
Take PrivilegedPipelineContent::script_to_compositor_port out of its …
8dadd1a 
…Option.
@Ms2ger
Consume self in PrivilegedPipelineContent methods.
Loading status checks…
9d73b86 
This leads to a little bit of copy/paste, but the resulting code should be
quite a bit more efficient.
@jdm
Copy link
Member

jdm commented Nov 26, 2015

r? @pcwalton
@pcwalton
Copy link
Contributor

pcwalton commented Nov 27, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2015

📌 Commit 9d73b86 has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2015

⌛ Testing commit 9d73b86 with merge 0e6c20d...
bors-servo added a commit that referenced this pull request Nov 27, 2015
@bors-servo
Auto merge of #8688 - Ms2ger:compositing, r=pcwalton
0e6c20d 
Some compositing cleanup.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8688)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2015

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Nov 27, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2015

⌛ Testing commit 9d73b86 with merge d103d26...
bors-servo added a commit that referenced this pull request Nov 27, 2015
@bors-servo
Auto merge of #8688 - Ms2ger:compositing, r=pcwalton
d103d26 
Some compositing cleanup.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8688)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 28, 2015

💔 Test failed - linux-rel
@eefriedman
Copy link
Contributor

eefriedman commented Nov 28, 2015

@bors-servo retry #8616
@bors-servo
Copy link
Contributor

bors-servo commented Nov 28, 2015

⌛ Testing commit 9d73b86 with merge fa7e1d0...
bors-servo added a commit that referenced this pull request Nov 28, 2015
@bors-servo
Auto merge of #8688 - Ms2ger:compositing, r=pcwalton
Loading status checks…
fa7e1d0 
Some compositing cleanup.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8688)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 28, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 9d73b86 into servo:master Nov 28, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:compositing branch Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Ms2ger @jdm @pcwalton @bors-servo @eefriedman @highfive
You can’t perform that action at this time.