Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IsPointInPath for Canvas #8740

Merged
merged 1 commit into from Dec 6, 2015
Merged

Implement IsPointInPath for Canvas #8740

merged 1 commit into from Dec 6, 2015

Conversation

@dzbarsky
Copy link
Member

dzbarsky commented Nov 30, 2015

Review on Reviewable
@dzbarsky
Copy link
Member Author

dzbarsky commented Nov 30, 2015

Depends on servo/rust-azure#208
@dzbarsky dzbarsky force-pushed the dzbarsky:ispointinpath branch from 2eac22f to dd53a2a Nov 30, 2015
@frewsxcv
Copy link
Member

frewsxcv commented Dec 1, 2015

servo/rust-azure#208 has merged.
@SimonSapin
Copy link
Member

SimonSapin commented Dec 3, 2015

This probably needs ./mach cargo-update -p azure as well. r=me with this.

@bors-servo delegate+

Reviewed 20 of 20 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Dec 3, 2015

✌️ @dzbarsky can now approve this pull request
@dzbarsky
Copy link
Member Author

dzbarsky commented Dec 4, 2015

➜ servo git:(ispointinpath) ✗ ./mach cargo-update -p azure
components/servo
Updating git repository https://github.com/servo/rust-azure
Updating registry https://github.com/rust-lang/crates.io-index
Package servo-glutin v0.4.3 does not have these features: xlib, xf86vmode, xcursor
ports/cef
Updating git repository https://github.com/servo/rust-azure
Updating registry https://github.com/rust-lang/crates.io-index
Package servo-glutin v0.4.3 does not have these features: xf86vmode, xlib, xcursor
ports/gonk
Updating git repository https://github.com/servo/rust-azure
Updating registry https://github.com/rust-lang/crates.io-index
Package servo-glutin v0.4.3 does not have these features: xf86vmode, xcursor, xlib

@SimonSapin any idea whats up?
@SimonSapin
Copy link
Member

SimonSapin commented Dec 4, 2015

Looks like the crate renames from #8757 are interfering. I reproduced this error locally, but it went away when I rebased on top of upstream/master.
@dzbarsky dzbarsky force-pushed the dzbarsky:ispointinpath branch from dd53a2a to ff3cf63 Dec 5, 2015
@dzbarsky
Copy link
Member Author

dzbarsky commented Dec 5, 2015

Looks like that worked, thanks
@dzbarsky dzbarsky force-pushed the dzbarsky:ispointinpath branch from ff3cf63 to 76c4597 Dec 5, 2015
@jdm
Copy link
Member

jdm commented Dec 5, 2015

@bors-servo: r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Dec 5, 2015

📌 Commit 76c4597 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Dec 5, 2015

⌛ Testing commit 76c4597 with merge 0d928ec...
bors-servo added a commit that referenced this pull request Dec 5, 2015
@bors-servo
Auto merge of #8740 - dzbarsky:ispointinpath, r=SimonSapin
0d928ec 
Implement IsPointInPath for Canvas

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8740)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 5, 2015

💔 Test failed - linux-dev
components/script/dom/canvasrenderingcontext2d.rs Outdated
@@ -695,6 +695,18 @@ impl CanvasRenderingContext2DMethods for CanvasRenderingContext2D {
self.ipc_renderer.send(CanvasMsg::Canvas2d(Canvas2dMsg::Clip)).unwrap();
}

fn IsPointInPath(&self, x: f64, y: f64, fill_rule: CanvasFillRule) -> bool {

This comment has been minimized.

Sign in to view
@frewsxcv

frewsxcv Dec 5, 2015

Member

Spec link needed here
@frewsxcv
Copy link
Member

frewsxcv commented Dec 5, 2015

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Dec 5, 2015

📌 Commit 2dac4c4 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Dec 5, 2015

⌛ Testing commit 2dac4c4 with merge d48492f...
bors-servo added a commit that referenced this pull request Dec 5, 2015
@bors-servo
Auto merge of #8740 - dzbarsky:ispointinpath, r=SimonSapin
d48492f 
Implement IsPointInPath for Canvas

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8740)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 5, 2015

💔 Test failed - mac-rel-wpt
@KiChjang
Copy link
Member

KiChjang commented Dec 5, 2015 

Ran 3728 tests finished in 869.0 seconds.
  • 3727 ran as expected. 707 tests skipped.
  • 1 tests had unexpected subtest results

Tests with unexpected results:
  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] CanvasRenderingContext2D interface: operation isPointInPath(unrestricted double,unrestricted double,CanvasFillRule)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] CanvasRenderingContext2D interface: operation isPointInPath(Path2D,unrestricted double,unrestricted double,CanvasFillRule)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] CanvasRenderingContext2D interface: document.createElement("canvas").getContext("2d") must inherit property "isPointInPath" with the proper type (42)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] CanvasRenderingContext2D interface: calling isPointInPath(unrestricted double,unrestricted double,CanvasFillRule) on document.createElement("canvas").getContext("2d") with too few arguments must throw TypeError

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] CanvasRenderingContext2D interface: document.createElement("canvas").getContext("2d") must inherit property "isPointInPath" with the proper type (43)

  ▶ Unexpected subtest result in /html/dom/interfaces.html:
  └ PASS [expected FAIL] CanvasRenderingContext2D interface: calling isPointInPath(Path2D,unrestricted double,unrestricted double,CanvasFillRule) on document.createElement("canvas").getContext("2d") with too few arguments must throw TypeError

Looking good!
@dzbarsky dzbarsky force-pushed the dzbarsky:ispointinpath branch from 2dac4c4 to 789a90a Dec 6, 2015
@dzbarsky
Copy link
Member Author

dzbarsky commented Dec 6, 2015

Can I get r+/delegate+ please?
@frewsxcv
Copy link
Member

frewsxcv commented Dec 6, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 6, 2015

📌 Commit 789a90a has been approved by frewsxcv
@bors-servo
Copy link
Contributor

bors-servo commented Dec 6, 2015

⌛ Testing commit 789a90a with merge 98972d0...
bors-servo added a commit that referenced this pull request Dec 6, 2015
@bors-servo
Auto merge of #8740 - dzbarsky:ispointinpath, r=frewsxcv
Loading status checks…
98972d0 
Implement IsPointInPath for Canvas

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8740)
<!-- Reviewable:end -->
@dzbarsky
Implement IsPointInPath
Loading status checks…
789a90a
@bors-servo
Copy link
Contributor

bors-servo commented Dec 6, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 789a90a into servo:master Dec 6, 2015
2 of 3 checks passed
2 of 3 checks passed
code-review/reviewable Review in progress: 15 of 23 files reviewed, 1 unresolved discussion
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@dzbarsky @frewsxcv @SimonSapin @bors-servo @jdm @KiChjang @highfive
You can’t perform that action at this time.