Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement basic framework for static and interactive validation on forms #8747
Conversation
KiChjang
force-pushed the
KiChjang:form-interactive-validation
branch
from
107fe54
to
39aebae
|
@bors-servo try |
Implement basic framework for static and interactive validation on forms This came along when I was trying to do #3648. I was about to do form validation as well, but then I saw it was actually intended to be a student project. Hopefully I didn't step on too many toes on this one; I did leave most of the important bits out (the fun bits I believe, e.g. interactive validation doesn't actually interactively validate anything right now). <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8747) <!-- Reviewable:end -->
|
|
KiChjang
force-pushed the
KiChjang:form-interactive-validation
branch
from
39aebae
to
d65a4ab
|
@bors-servo try |
Implement basic framework for static and interactive validation on forms This came along when I was trying to do #3648. I was about to do form validation as well, but then I saw it was actually intended to be a student project. Hopefully I didn't step on too many toes on this one; I did leave most of the important bits out (the fun bits I believe, e.g. interactive validation doesn't actually interactively validate anything right now). <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8747) <!-- Reviewable:end -->
|
|
|
r? @Manishearth |
|
@bors-servo try |
|
|
Implement basic framework for static and interactive validation on forms This came along when I was trying to do #3648. I was about to do form validation as well, but then I saw it was actually intended to be a student project. Hopefully I didn't step on too many toes on this one; I did leave most of the important bits out (the fun bits I believe, e.g. interactive validation doesn't actually interactively validate anything right now). <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8747) <!-- Reviewable:end -->
|
|
KiChjang
force-pushed the
KiChjang:form-interactive-validation
branch
4 times, most recently
from
1b320f8
to
debeb13
KiChjang
force-pushed the
KiChjang:form-interactive-validation
branch
2 times, most recently
from
c8646f9
to
5687158
|
What's the status of this? Looks like @Manishearth already approved this EDIT: Oh, possibly waiting on input from @jdm |
|
|
KiChjang
force-pushed the
KiChjang:form-interactive-validation
branch
from
5687158
to
614690c
|
|
KiChjang
force-pushed the
KiChjang:form-interactive-validation
branch
from
614690c
to
3395e54
|
I'm fine with most of these changes, but I'm less keen on the big block of commented code at https://github.com/servo/servo/pull/8747/files#diff-db2031d1f23ecf1a921fc100cfed753dR273 . I'd prefer to merge this with that removed. |
|
Done. |
|
@bors-servo: r=Manishearth |
|
|
|
|
…arth Implement basic framework for static and interactive validation on forms This came along when I was trying to do #3648. I was about to do form validation as well, but then I saw it was actually intended to be a student project. Hopefully I didn't step on too many toes on this one; I did leave most of the important bits out (the fun bits I believe, e.g. interactive validation doesn't actually interactively validate anything right now). <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8747) <!-- Reviewable:end -->
|
|
KiChjang commentedNov 30, 2015
This came along when I was trying to do #3648. I was about to do form validation as well, but then I saw it was actually intended to be a student project. Hopefully I didn't step on too many toes on this one; I did leave most of the important bits out (the fun bits I believe, e.g. interactive validation doesn't actually interactively validate anything right now).