Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ZERO_RECT with Rect::zero() #8795

Merged
merged 1 commit into from Dec 3, 2015
Merged

Replace ZERO_RECT with Rect::zero() #8795

merged 1 commit into from Dec 3, 2015

Conversation

@pointlessone
Copy link
Contributor

pointlessone commented Dec 3, 2015

This is a proposed in #8792 clean up.

Review on Reviewable
@pointlessone
Replaced ZERO_RECT with Rect::zero()
Loading status checks…
546d2f5
@highfive
Copy link

highfive commented Dec 3, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @mbrubeck (or someone else) soon.
@highfive
Copy link

highfive commented Dec 3, 2015

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
@SimonSapin
Copy link
Member

SimonSapin commented Dec 3, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 3, 2015

📌 Commit 546d2f5 has been approved by SimonSapin
@SimonSapin SimonSapin mentioned this pull request Dec 3, 2015
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Dec 3, 2015

⌛ Testing commit 546d2f5 with merge 3995a76...
bors-servo added a commit that referenced this pull request Dec 3, 2015
@bors-servo
Auto merge of #8795 - cheba:zero-rect, r=SimonSapin
Loading status checks…
3995a76 
Replace ZERO_RECT with Rect::zero()

This is a proposed in #8792 clean up.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8795)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 3, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 546d2f5 into servo:master Dec 3, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@pointlessone pointlessone deleted the pointlessone:zero-rect branch Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@pointlessone @highfive @SimonSapin @bors-servo
You can’t perform that action at this time.