Replaced ZERO_POINT with Point2D::zero()

[pointlessone]

This is a proposed in #8792 clean up.

Fixes #8792.

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @mbrubeck (or someone else) soon.

[highfive]

Warning

• These commits modify layout code, but no reftests are modified. Please consider adding a reftest!

[SimonSapin]

@bors-servo r+

Looks good, thanks! By the way, related changes like #8795 and this can be made with multiple commits in the same PR. You can also add commits to a PR after opening it. (No need to change these now, though.)

[bors-servo]

📌 Commit f15ce9f has been approved by SimonSapin

[pointlessone]

@SimonSapin Thanks for the tip.

[bors-servo]

☔ The latest upstream changes (presumably #8795) made this pull request unmergeable. Please resolve the merge conflicts.

[SimonSapin]

Not sure why bors says it’s unmergeable, Github seems fine with it.

@bors-servo r+

[bors-servo]

📌 Commit ee746e2 has been approved by SimonSapin

[SimonSapin]

Oh, you’ve already rebased :)

There’s no email notification when new commits are pushed in a PR, so feel free to add a comment when you do.

[bors-servo]

⌛ Testing commit ee746e2 with merge d40051f...

[bors-servo]

💔 Test failed - linux-rel

[KiChjang]

Ran 3726 tests finished in 198.0 seconds.
  • 3725 ran as expected. 708 tests skipped.
  • 1 tests timed out unexpectedly

Tests with unexpected results:
  ▶ TIMEOUT [expected FAIL] /html/dom/elements/global-attributes/dir_auto-N-EN.html
  │ 
  │ was ready to save, resetting ready_to_save_state
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ was ready to save, resetting ready_to_save_state
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ thread 'Constellation' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 104, message: "Connection reset by peer" } }', ../src/libcore/result.rs:741
  │ stack backtrace:
  │    1:     0x7feb8058e3a0 - sys::backtrace::tracing::imp::write::h064b2475ee0d772cxXt
  │    2:     0x7feb805912d5 - panicking::log_panic::_<closure>::closure.40992
  │    3:     0x7feb80590d50 - panicking::log_panic::h29f8d24759545d7862x
  │    4:     0x7feb8057a003 - sys_common::unwind::begin_unwind_inner::hdadcc96a1ecb24974Ps
  │    5:     0x7feb8057a6b8 - sys_common::unwind::begin_unwind_fmt::h9442bd88fc02b35caPs
  │    6:     0x7feb8058da01 - rust_begin_unwind
  │    7:     0x7feb805be46f - panicking::panic_fmt::h2f3428e3725b99d6VFK
  │    8:     0x7feb7ef6dc65 - constellation::_<impl>::handle_is_ready_to_save_image::handle_is_ready_to_save_image::h7464060649015599629
  │    9:     0x7feb7eefb4e5 - constellation::_<impl>::handle_request::handle_request::h2512767965772658699
  │   10:     0x7feb7eee5f47 - sys_common::unwind::try::try_fn::try_fn::h18033304662745029905
  │   11:     0x7feb8058d848 - __rust_try
  │   12:     0x7feb80589c1b - sys_common::unwind::try::inner_try::hb6fbb19d6020cb51CMs
  │   13:     0x7feb7eee81ba - boxed::_<impl>::call_box::call_box::h3977225798282015024
  │   14:     0x7feb8058fc33 - sys::thread::_<impl>::new::thread_start::h51b5333730e2e1a3I5w
  │   15:     0x7feb7c53a181 - start_thread
  │   16:     0x7feb7cd5447c - __clone
  └   17:                0x0 - <unknown>

[KiChjang]

@bors-servo retry

• #8815

[bors-servo]

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...

[bors-servo]

💔 Test failed - linux-rel

[KiChjang]

Ran 3726 tests finished in 198.0 seconds.
  • 3725 ran as expected. 708 tests skipped.
  • 1 tests failed unexpectedly

Tests with unexpected results:
  ▶ FAIL [expected PASS] /_mozilla/css/iframe/positioning_margin.html
  └   → /_mozilla/css/iframe/positioning_margin.html d9d9e489bc5b4508c01b06c7ff92f19dcc2ece3c
/_mozilla/css/iframe/positioning_margin_ref.html 3a4684450cbc08c6e80ab78eb761e71881c74ab1
Testing d9d9e489bc5b4508c01b06c7ff92f19dcc2ece3c == 3a4684450cbc08c6e80ab78eb761e71881c74ab1

[jdm]

@bors-servo: retry

• #8816

[bors-servo]

⌛ Testing commit ee746e2 with merge 2dbc314...

[bors-servo]

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

[pointlessone]

There’s no email notification when new commits are pushed in a PR, so feel free to add a comment when you do.

Will do.

Is this OK for tests to pass only after multiple retries?

[SimonSapin]

Some of our tests are known to have "intermittent" results. This is a bug, but it’s sometimes hard to track down. When it gets bad we sometimes disable some tests. To avoid bloking everything, it’s acceptable to retry when linking to an issue like #8815 about the relevant test, opening one if necessary.