Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced rect_contains_point with Rect.contains() #8797

Merged
merged 1 commit into from Dec 4, 2015

Conversation

@pointlessone
Copy link
Contributor

pointlessone commented Dec 3, 2015

This is a proposed in #8791 clean up.

Fixes #8791.

Review on Reviewable

@highfive
Copy link

highfive commented Dec 3, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

@Manishearth
Copy link
Member

Manishearth commented Dec 3, 2015

@bors-servo r+

Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Dec 3, 2015

📌 Commit 96a8b44 has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Dec 3, 2015

Testing commit 96a8b44 with merge 68922e0...

bors-servo added a commit that referenced this pull request Dec 3, 2015
Replaced rect_contains_point with Rect.contains()

This is a proposed in #8791 clean up.

Fixes #8791.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8797)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 3, 2015

💔 Test failed - mac-rel-wpt

@KiChjang
Copy link
Member

KiChjang commented Dec 3, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Dec 3, 2015

Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...

@bors-servo
Copy link
Contributor

bors-servo commented Dec 4, 2015

@bors-servo bors-servo merged commit 96a8b44 into servo:master Dec 4, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@pointlessone pointlessone deleted the pointlessone:rect-contains branch Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.