Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced rect_contains_point with Rect.contains() #8797

Merged
merged 1 commit into from Dec 4, 2015
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Replaced rect_contains_point with Rect.contains()

  • Loading branch information
pointlessone committed Dec 3, 2015
commit 96a8b442b856ab41c088eb7d1911842a703a7484
@@ -397,7 +397,7 @@ impl DisplayList {
// Clipped out.
return;
}
if !geometry::rect_contains_point(item.bounds(), point) {
if !item.bounds().contains(&point) {
// Can't possibly hit.
return;
}
@@ -420,7 +420,7 @@ impl DisplayList {
border.base.bounds.size.height -
(border.border_widths.top +
border.border_widths.bottom)));
if geometry::rect_contains_point(interior_rect, point) {
if interior_rect.contains(&point) {
return;
}
}
@@ -1089,8 +1089,8 @@ impl ClippingRegion {
/// This is a quick, not a precise, test; it can yield false positives.
#[inline]
pub fn might_intersect_point(&self, point: &Point2D<Au>) -> bool {
geometry::rect_contains_point(self.main, *point) &&
self.complex.iter().all(|complex| geometry::rect_contains_point(complex.rect, *point))
self.main.contains(point) &&
self.complex.iter().all(|complex| complex.rect.contains(point))
}

/// Returns true if this clipping region might intersect the given rectangle and false
@@ -86,16 +86,6 @@ pub static MAX_RECT: Rect<Au> = Rect {
}
};

/// Returns true if the rect contains the given point. Points on the top or left sides of the rect
/// are considered inside the rectangle, while points on the right or bottom sides of the rect are
/// not considered inside the rectangle.
pub fn rect_contains_point<T>(rect: Rect<T>, point: Point2D<T>) -> bool
where T: PartialOrd + Add<T, Output=T>
{
point.x >= rect.origin.x && point.x < rect.origin.x + rect.size.width &&
point.y >= rect.origin.y && point.y < rect.origin.y + rect.size.height
}

/// A helper function to convert a rect of `f32` pixels to a rect of app units.
pub fn f32_rect_to_au_rect(rect: Rect<f32>) -> Rect<Au> {
Rect::new(Point2D::new(Au::from_f32_px(rect.origin.x), Au::from_f32_px(rect.origin.y)),
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.