Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake the global object be the Window object. Fixes #833. #883
Conversation
|
r? @kmc . Fixed the extraneous fixed_stack_segment and C string with_ref. |
This comment has been minimized.
This comment has been minimized.
kmcallister
commented on da599c6
Sep 10, 2013
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from kmcallister |
This comment has been minimized.
This comment has been minimized.
|
merging jdm/servo/newglobal = da599c6 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 0dd90c7 |
bors-servo
pushed a commit
that referenced
this pull request
Sep 10, 2013
Requires servo/rust-mozjs#34.
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
…owRoot shadow dom: no entry corresponding to the test in specification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedSep 6, 2013
Requires servo/rust-mozjs#34.