Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat 'undefined' passed to an optional argument as "missing" #8849

Closed
wants to merge 1 commit into from
Closed

Treat 'undefined' passed to an optional argument as "missing" #8849

wants to merge 1 commit into from

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Dec 5, 2015

Fixes #8813

Review on Reviewable
@frewsxcv
Treat 'undefined' passed to an optional argument as "missing"
Loading status checks…
8432155 
Fixes #8813
@KiChjang
Copy link
Member

KiChjang commented Dec 6, 2015

I'm kind of curious why this only checks for undefined against the case where there is no defaultValue. Shouldn't it also check whether arguments with a defaultValue have an undefined passed onto them?
@KiChjang
Copy link
Member

KiChjang commented Dec 6, 2015

I've opened #8854 which addresses the same issue but with a different implementation. Please let me know whether I messed up or not!
@KiChjang
Copy link
Member

KiChjang commented Dec 6, 2015

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Dec 6, 2015

⌛ Trying commit 8432155 with merge b7d5928...
bors-servo added a commit that referenced this pull request Dec 6, 2015
@bors-servo
Auto merge of #8849 - frewsxcv:passing-undefined-into-optional-argume…
b7d5928 
…nt, r=<try>

Treat 'undefined' passed to an optional argument as "missing"

Fixes #8813

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8849)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 6, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@frewsxcv
Copy link
Member Author

frewsxcv commented Dec 7, 2015

This might get superseded by #8854
@frewsxcv
Copy link
Member Author

frewsxcv commented Dec 7, 2015

Closing in favor of #8854
@frewsxcv frewsxcv closed this Dec 7, 2015
@frewsxcv frewsxcv deleted the frewsxcv:passing-undefined-into-optional-argument branch Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@frewsxcv @KiChjang @bors-servo @highfive
You can’t perform that action at this time.