Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMoved WorkerId type to devtools_traits #8862
Conversation
highfive
commented
Dec 6, 2015
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon. |
|
Thanks for the PR! Unfortunately our "tidy" check caught one small mistake; see below. Let me know when you've made the change? -S-awaiting-review +S-needs-code-changes Reviewed 9 of 9 files at r1. components/script/dom/window.rs, line 7 [r1] (raw file): Comments from the review on Reviewable.io |
|
components/script/dom/window.rs, line 7 [r1] (raw file): Sometimes, they are all chained in one line. Interestingly, what works for the tidy check is
|
|
Thank you. Can you please squash the two commits now? -S-awaiting-review +S-needs-squash Reviewed 1 of 1 files at r2. Comments from the review on Reviewable.io |
|
Done! |
|
Thanks again, your help is much appreciated. @bors-servo r+ |
|
|
|
|
Moved WorkerId type to devtools_traits Fixes #8846. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8862) <!-- Reviewable:end -->
|
|
fstr commentedDec 6, 2015
Fixes #8846.