Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove websocket creation to resource task #8867
Conversation
|
|
|
This looks really great! There are a couple changes we can make for efficiency, but I'm really happy with how this PR turned out :D Reviewed 8 of 8 files at r1. components/net/resource_task.rs, line 180 [r1] (raw file): components/net/resource_task.rs, line 359 [r1] (raw file): components/net/websocket_loader.rs, line 45 [r1] (raw file): components/net/websocket_loader.rs, line 57 [r1] (raw file): components/net/websocket_loader.rs, line 120 [r1] (raw file): components/script/dom/websocket.rs, line 143 [r1] (raw file): components/script/dom/websocket.rs, line 239 [r1] (raw file): components/servo/Cargo.lock, line 1159 [r1] (raw file): Comments from the review on Reviewable.io |
|
Made a new commit with the updates so you can see the changes more easily, but I can squash the commits when the PR is ready! |
|
One last change required - please squash the commits together while doing so, and I'll merge it :) Reviewed 6 of 6 files at r2. components/net/websocket_loader.rs, line 45 [r1] (raw file): Comments from the review on Reviewable.io |
|
@bors-servo r=jdm |
|
|
Move websocket creation to resource task This is a pull request for part of #6638 It includes the following changes: -The websocket networking code (ie. making a connection, receiving data, and sending data) has been extracted out of components/script/dom/websocket.rs and into the new file components/net/websocket_loader.rs. -websocket.rs now communicates with the resource task (components/net/resource_task.rs) to instruct it to initiate a new websocket connection - websocket_loader.rs now provides an API sent over an IPCChannel that allows websocket.rs to receive feedback about this process and to subsequently send and receive data <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8867) <!-- Reviewable:end -->
|
|
nfallen commentedDec 7, 2015
This is a pull request for part of #6638
It includes the following changes:
-The websocket networking code (ie. making a connection, receiving data, and sending data) has been extracted out of components/script/dom/websocket.rs and into the new file components/net/websocket_loader.rs.
-websocket.rs now communicates with the resource task (components/net/resource_task.rs) to instruct it to initiate a new websocket connection