Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGL nits #8876

Merged
merged 2 commits into from Dec 7, 2015
Merged

WebGL nits #8876

merged 2 commits into from Dec 7, 2015

Conversation

@emilio
Copy link
Member

emilio commented Dec 7, 2015

This improves support for running our triangle test (see: #8831), and adds missing error in BufferSubData

Review on Reviewable

emilio added 2 commits Dec 7, 2015
Support for this should be almost universal.
From the WebGL spec:

> If data is null then an INVALID_VALUE error is generated.
@emilio
Copy link
Member Author

emilio commented Dec 7, 2015

r? @jdm

@jdm
Copy link
Member

jdm commented Dec 7, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2015

📌 Commit a14b605 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2015

Testing commit a14b605 with merge 26de772...

bors-servo added a commit that referenced this pull request Dec 7, 2015
WebGL nits

This improves support for running our triangle test (see: #8831), and adds missing error in `BufferSubData`

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8876)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2015

💔 Test failed - linux-rel

@KiChjang
Copy link
Member

KiChjang commented Dec 7, 2015

Ran 6932 tests finished in 964.0 seconds.
  • 6930 ran as expected. 8 tests skipped.
  • 2 tests timed out unexpectedly

Tests with unexpected results:
  ▶ TIMEOUT [expected FAIL] /css-flexbox-1_dev/html/flexbox-basic-iframe-vert-001.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ was ready to save, resetting ready_to_save_state
  └ Shutting down the Constellation after generating an output file or exit flag specified

  ▶ TIMEOUT [expected FAIL] /css-flexbox-1_dev/html/flexbox-basic-iframe-horiz-001.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ was ready to save, resetting ready_to_save_state
  └ Shutting down the Constellation after generating an output file or exit flag specified
@KiChjang
Copy link
Member

KiChjang commented Dec 7, 2015

@jdm
Copy link
Member

jdm commented Dec 7, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2015

Testing commit a14b605 with merge 743be46...

bors-servo added a commit that referenced this pull request Dec 7, 2015
WebGL nits

This improves support for running our triangle test (see: #8831), and adds missing error in `BufferSubData`

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8876)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2015

💔 Test failed - linux-dev

@KiChjang
Copy link
Member

KiChjang commented Dec 7, 2015

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2015

Previous build results for android, gonk, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-dev, linux-rel...

@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2015

💔 Test failed - linux-dev

@KiChjang KiChjang reopened this Dec 7, 2015
@KiChjang
Copy link
Member

KiChjang commented Dec 7, 2015

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2015

Testing commit a14b605 with merge d8f68a4...

bors-servo added a commit that referenced this pull request Dec 7, 2015
WebGL nits

This improves support for running our triangle test (see: #8831), and adds missing error in `BufferSubData`

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8876)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2015

💔 Test failed - linux-rel

@KiChjang
Copy link
Member

KiChjang commented Dec 7, 2015

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2015

Testing commit a14b605 with merge 9cccd34...

bors-servo added a commit that referenced this pull request Dec 7, 2015
WebGL nits

This improves support for running our triangle test (see: #8831), and adds missing error in `BufferSubData`

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8876)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2015

@bors-servo bors-servo merged commit a14b605 into servo:master Dec 7, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.