Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wptrunner for some old-style reftests. #8880

Merged
merged 3 commits into from Dec 9, 2015
Merged

Use wptrunner for some old-style reftests. #8880

merged 3 commits into from Dec 9, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 7, 2015

Review on Reviewable
Ms2ger added 2 commits Dec 7, 2015
@Ms2ger
Move acid2_noscroll.html to wpt reftests.
82183ae
@Ms2ger
Move append_style_a.html to wpt reftests.
29feccd
@frewsxcv frewsxcv self-assigned this Dec 7, 2015
@frewsxcv
Copy link
Member

frewsxcv commented Dec 7, 2015

Reviewed 16 of 16 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

tests/ref/basic.list, line 7 [r1] (raw file):
Did this not make the cut?

Comments from the review on Reviewable.io
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Dec 7, 2015

@bors-servo r=frewsxcv

(On IRC)
@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2015

📌 Commit 51a87b5 has been approved by frewsxcv
@bors-servo
Copy link
Contributor

bors-servo commented Dec 7, 2015

⌛ Testing commit 51a87b5 with merge 43b4abc...
bors-servo added a commit that referenced this pull request Dec 7, 2015
@bors-servo
Auto merge of #8880 - Ms2ger:test-ref, r=frewsxcv
43b4abc 
Use wptrunner for some old-style reftests.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8880)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2015

💔 Test failed - mac-rel-wpt
@KiChjang
Copy link
Member

KiChjang commented Dec 8, 2015 


Ran 3732 tests finished in 864.0 seconds.
  • 3731 ran as expected. 707 tests skipped.
  • 1 tests failed unexpectedly

Tests with unexpected results:
  ▶ FAIL [expected PASS] /_mozilla/css/white_space_intrinsic_sizes_a.html
  └   → /_mozilla/css/white_space_intrinsic_sizes_a.html 2aac789a4ba9d3c3531f650eb61d3c0ed1d778c8
/_mozilla/css/white_space_intrinsic_sizes_ref.html 62a10a3c39c1958ffe988cc164fd57dfba255fdf
Testing 2aac789a4ba9d3c3531f650eb61d3c0ed1d778c8 == 62a10a3c39c1958ffe988cc164fd57dfba255fdf
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Dec 8, 2015

@bors-servo retry

Trying to see if it's intermittent or permanent
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2015

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2015

💔 Test failed - mac-rel-wpt
@KiChjang
Copy link
Member

KiChjang commented Dec 8, 2015 


Ran 3732 tests finished in 862.0 seconds.
  • 3731 ran as expected. 707 tests skipped.
  • 1 tests failed unexpectedly

Tests with unexpected results:
  ▶ FAIL [expected PASS] /_mozilla/css/white_space_intrinsic_sizes_a.html
  └   → /_mozilla/css/white_space_intrinsic_sizes_a.html 2aac789a4ba9d3c3531f650eb61d3c0ed1d778c8
/_mozilla/css/white_space_intrinsic_sizes_ref.html 62a10a3c39c1958ffe988cc164fd57dfba255fdf
Testing 2aac789a4ba9d3c3531f650eb61d3c0ed1d778c8 == 62a10a3c39c1958ffe988cc164fd57dfba255fdf
@KiChjang
Copy link
Member

KiChjang commented Dec 8, 2015

Looks like it's permanent damage.
@frewsxcv
Copy link
Member

frewsxcv commented Dec 8, 2015

fwiw, it was marked as flaky before, so this could have always been the case prior to this
@frewsxcv
Copy link
Member

frewsxcv commented Dec 8, 2015

Image diff on OSX btw:

meow
@Ms2ger Ms2ger force-pushed the Ms2ger:test-ref branch from 51a87b5 to 2d29eb9 Dec 8, 2015
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Dec 8, 2015

@bors-servo r=frewsxcv
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2015

📌 Commit 2d29eb9 has been approved by frewsxcv
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2015

⌛ Testing commit 2d29eb9 with merge 97e509a...
bors-servo added a commit that referenced this pull request Dec 8, 2015
@bors-servo
Auto merge of #8880 - Ms2ger:test-ref, r=frewsxcv
97e509a 
Use wptrunner for some old-style reftests.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8880)
<!-- Reviewable:end -->
@frewsxcv frewsxcv mentioned this pull request Dec 8, 2015
Open
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2015

💔 Test failed - mac-rel-wpt
@Ms2ger
Move white_space_intrinsic_sizes_a.html to wpt reftests.
Loading status checks…
844965e
@Ms2ger Ms2ger force-pushed the Ms2ger:test-ref branch from 2d29eb9 to 844965e Dec 9, 2015
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Dec 9, 2015

@bors-servo r=frewsxcv
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2015

📌 Commit 844965e has been approved by frewsxcv
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2015

⌛ Testing commit 844965e with merge 8ba470d...
bors-servo added a commit that referenced this pull request Dec 9, 2015
@bors-servo
Auto merge of #8880 - Ms2ger:test-ref, r=frewsxcv
Loading status checks…
8ba470d 
Use wptrunner for some old-style reftests.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8880)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2015

⛄ The build was interrupted to prioritize another pull request.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2015

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 844965e into servo:master Dec 9, 2015
2 of 3 checks passed
2 of 3 checks passed
code-review/reviewable Review in progress: 16 of 17 files reviewed, 1 unresolved discussion
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:test-ref branch Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frewsxcv frewsxcv

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @frewsxcv @bors-servo @KiChjang @highfive
You can’t perform that action at this time.