Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade some dependencies #8884

Merged
merged 4 commits into from Dec 9, 2015
Merged

Upgrade some dependencies #8884

merged 4 commits into from Dec 9, 2015

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Dec 8, 2015

Review on Reviewable
@frewsxcv
Copy link
Member Author

frewsxcv commented Dec 8, 2015

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2015

⌛ Trying commit 8149058 with merge 62f15c5...
@frewsxcv
Copy link
Member Author

frewsxcv commented Dec 8, 2015

@bors-servo try
bors-servo added a commit that referenced this pull request Dec 8, 2015
@bors-servo
Auto merge of #8884 - frewsxcv:update-packages, r=<try>
62f15c5 
Upgrade some dependencies

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8884)
<!-- Reviewable:end -->
@frewsxcv
Copy link
Member Author

frewsxcv commented Dec 8, 2015

@bors-servo try
@mbrubeck
Copy link
Contributor

mbrubeck commented Dec 8, 2015

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io
@mbrubeck
Copy link
Contributor

mbrubeck commented Dec 8, 2015

r=mbrubeck, assuming the try build succeeds
@mbrubeck mbrubeck self-assigned this Dec 8, 2015
@frewsxcv
Copy link
Member Author

frewsxcv commented Dec 8, 2015

@bors-servo r=mbrubeck

Builders didn't finish 'try'ing this, just going to move forward
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2015

📌 Commit 8149058 has been approved by mbrubeck
@frewsxcv
Copy link
Member Author

frewsxcv commented Dec 8, 2015

@bors-servo try- r=mbrubeck force
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2015

📌 Commit 8149058 has been approved by mbrubeck
@frewsxcv frewsxcv force-pushed the frewsxcv:update-packages branch from 8149058 to 2824a2b Dec 8, 2015
@frewsxcv
Copy link
Member Author

frewsxcv commented Dec 8, 2015

@bors-servo r=mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2015

📌 Commit 2824a2b has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2015

⌛ Testing commit 2824a2b with merge 933952a...
bors-servo added a commit that referenced this pull request Dec 8, 2015
@bors-servo
Auto merge of #8884 - frewsxcv:update-packages, r=mbrubeck
933952a 
Upgrade some dependencies

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8884)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2015

💔 Test failed - android
@KiChjang
Copy link
Member

KiChjang commented Dec 8, 2015

Oh noes! gaol failed to compile!
/cc @pcwalton
@mbrubeck
Copy link
Contributor

mbrubeck commented Dec 8, 2015

This might be a libc mismatch issue. gaol has several * dependencies.

/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/namespace.rs:64:19: 64:33 error: mismatched types:
 expected `*const i8`,
    found `*const u8`
(expected i8,
    found u8) [E0308]
/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/namespace.rs:64             mount(tmpfs.as_ptr(),
                                                                                                               ^~~~~~~~~~~~~~
@frewsxcv
Copy link
Member Author

frewsxcv commented Dec 8, 2015

Somewhat related: https://github.com/pcwalton/gaol/pull/8
@mbrubeck
Copy link
Contributor

mbrubeck commented Dec 8, 2015

I can confirm that pcwalton/gaol#8 fixes the Android build.
frewsxcv added 2 commits Dec 8, 2015
@frewsxcv
Upgrade dependency: ipc-channel
0316f0b 
servo/ipc-channel@8306cdf...6900611
@frewsxcv
Upgrade dependency: gaol
389d5b4 
pcwalton/gaol@71865ff...e1349d8
@frewsxcv frewsxcv force-pushed the frewsxcv:update-packages branch from 2824a2b to 6d87f76 Dec 9, 2015
frewsxcv added 2 commits Dec 8, 2015
@frewsxcv
Upgrade dependency: malloc_buf
0919f81 
SSheldon/malloc_buf@bab724c...a7811e5
@frewsxcv
Upgrade dependency: shared_library
Loading status checks…
c7e6268 
tomaka/shared_library@8c6d243...391e74a
@frewsxcv frewsxcv force-pushed the frewsxcv:update-packages branch from 6d87f76 to c7e6268 Dec 9, 2015
@frewsxcv
Copy link
Member Author

frewsxcv commented Dec 9, 2015

@bors-servo r=mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2015

📌 Commit c7e6268 has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2015

⌛ Testing commit c7e6268 with merge 452b55b...
bors-servo added a commit that referenced this pull request Dec 9, 2015
@bors-servo
Auto merge of #8884 - frewsxcv:update-packages, r=mbrubeck
Loading status checks…
452b55b 
Upgrade some dependencies

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8884)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit c7e6268 into servo:master Dec 9, 2015
2 of 3 checks passed
2 of 3 checks passed
code-review/reviewable Review in progress: 0 of 3 files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv mentioned this pull request Dec 9, 2015
Closed
@frewsxcv frewsxcv deleted the frewsxcv:update-packages branch Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
S-awaiting-merge S-blocked-on-external
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@frewsxcv @bors-servo @mbrubeck @KiChjang @highfive
You can’t perform that action at this time.