Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings: Use Vec.extend_from_slice instead of Vec.push_all #8922

Merged
merged 1 commit into from Dec 11, 2015
Merged

Fix warnings: Use Vec.extend_from_slice instead of Vec.push_all #8922

merged 1 commit into from Dec 11, 2015

Conversation

@tetsuharuohzeki
Copy link
Member

tetsuharuohzeki commented Dec 10, 2015

Review on Reviewable
@highfive
Copy link

highfive commented Dec 10, 2015

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 10, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2015

📌 Commit 53b60c9 has been approved by Ms2ger
@mbrubeck
Copy link
Contributor

mbrubeck commented Dec 10, 2015

@bors-servo r-

Sorry, one nit.

-S-awaiting-merge +S-needs-code-changes

Review status: 0 of 18 files reviewed at latest revision, 2 unresolved discussions.

components/layout/construct.rs, line 180 [r1] (raw file):
I think this function should not be renamed.

components/layout/construct.rs, line 231 [r1] (raw file):
I think this function should not be renamed.

Comments from the review on Reviewable.io
@tetsuharuohzeki tetsuharuohzeki mentioned this pull request Dec 10, 2015
Merged
@tetsuharuohzeki tetsuharuohzeki force-pushed the tetsuharuohzeki:warning branch from 53b60c9 to 6b75e01 Dec 10, 2015
@tetsuharuohzeki tetsuharuohzeki force-pushed the tetsuharuohzeki:warning branch from 6b75e01 to e68c63f Dec 10, 2015
@tetsuharuohzeki
Copy link
Member Author

tetsuharuohzeki commented Dec 10, 2015

oops! I replace them mechanically

Review status: 0 of 18 files reviewed at latest revision, 2 unresolved discussions.

components/layout/construct.rs, line 180 [r1] (raw file):
fixed

components/layout/construct.rs, line 231 [r1] (raw file):
fixed

Comments from the review on Reviewable.io
@mbrubeck
Copy link
Contributor

mbrubeck commented Dec 10, 2015

Reviewed 17 of 18 files at r1, 1 of 1 files at r2.
Review status: 17 of 18 files reviewed at latest revision, 1 unresolved discussion.

components/layout/construct.rs, line 548 [r1] (raw file):
All the changes in this file should be reverted, because this method is no longer renamed.

Comments from the review on Reviewable.io
@tetsuharuohzeki
Fix warnings: Use Vec.extend_from_slice instead of Vec.push_all
Loading status checks…
e8c12c1
@tetsuharuohzeki
Copy link
Member Author

tetsuharuohzeki commented Dec 10, 2015

All the changes in this file should be reverted, because this method is no longer renamed.

Sorry!
@tetsuharuohzeki tetsuharuohzeki force-pushed the tetsuharuohzeki:warning branch from e68c63f to e8c12c1 Dec 10, 2015
@mbrubeck
Copy link
Contributor

mbrubeck commented Dec 10, 2015

Reviewed 1 of 18 files at r1, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.

Comments from the review on Reviewable.io
@mbrubeck
Copy link
Contributor

mbrubeck commented Dec 10, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2015

📌 Commit e8c12c1 has been approved by mbrubeck
bors-servo added a commit that referenced this pull request Dec 10, 2015
@bors-servo
Auto merge of #8922 - saneyuki:warning, r=mbrubeck
Loading status checks…
d01233a 
Fix warnings: Use Vec.extend_from_slice instead of Vec.push_all

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8922)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2015

⌛ Testing commit e8c12c1 with merge d01233a...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit e8c12c1 into servo:master Dec 11, 2015
2 of 3 checks passed
2 of 3 checks passed
code-review/reviewable Review in progress: all files reviewed, 1 unresolved discussion
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Dec 11, 2015
Merged
@frewsxcv frewsxcv mentioned this pull request Dec 11, 2015
Closed
@tetsuharuohzeki tetsuharuohzeki deleted the tetsuharuohzeki:warning branch Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@tetsuharuohzeki @highfive @Ms2ger @bors-servo @mbrubeck
You can’t perform that action at this time.