Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning: Use iterator.min_by_key instead of iterator.min_by #8923

Merged
merged 1 commit into from Dec 11, 2015
Merged

Fix warning: Use iterator.min_by_key instead of iterator.min_by #8923

merged 1 commit into from Dec 11, 2015
+1 −1

Conversation

@tetsuharuohzeki
Copy link
Member

tetsuharuohzeki commented Dec 10, 2015

Review on Reviewable
@highfive
Copy link

highfive commented Dec 10, 2015

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
@tetsuharuohzeki
Fix warning: Use iterator.min_by_key instead of iterator.min_by
Loading status checks…
eff54f3
@tetsuharuohzeki tetsuharuohzeki force-pushed the tetsuharuohzeki:warning2 branch from d0bc2bc to eff54f3 Dec 10, 2015
@nox nox self-assigned this Dec 10, 2015
@nox
Copy link
Member

nox commented Dec 10, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2015

📌 Commit eff54f3 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2015

⌛ Testing commit eff54f3 with merge 5cfaad4...
bors-servo added a commit that referenced this pull request Dec 11, 2015
@bors-servo
Auto merge of #8923 - saneyuki:warning2, r=nox
5cfaad4 
Fix warning: Use iterator.min_by_key instead of iterator.min_by

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8923)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2015

💔 Test failed - mac-rel-wpt
@KiChjang
Copy link
Member

KiChjang commented Dec 11, 2015 

Ran 3733 tests finished in 864.0 seconds.
  • 3732 ran as expected. 708 tests skipped.
  • 1 tests timed out unexpectedly

Tests with unexpected results:
  ▶ TIMEOUT [expected PASS] /_mozilla/css/iframe/hide_layers2.html
  │ 
  │ thread 'Constellation' panicked at 'unable to find pipeline - this is a bug', ../src/libcore/option.rs:335
  │ stack backtrace:
  │    1:        0x10f919df8 - sys::backtrace::tracing::imp::write::hca66179add43b2e5lLt
  │    2:        0x10f91bebf - panicking::log_panic::_<closure>::closure.40842
  │    3:        0x10f91b962 - panicking::log_panic::h7a04edac7e1f2797HEx
  │    4:        0x10f9076a6 - sys_common::unwind::begin_unwind_inner::h39a94087039ae0efnOs
  │    5:        0x10f907a8e - sys_common::unwind::begin_unwind_fmt::h7be0824d83765cd5tNs
  │    6:        0x10f919417 - rust_begin_unwind
  │    7:        0x10f93e4a0 - panicking::panic_fmt::h871c0ef100fda9e9LFK
  │    8:        0x10e3271ed - constellation::_<impl>::handle_request::handle_request::h2799929052455725810
  │    9:        0x10e30c317 - sys_common::unwind::try::try_fn::try_fn::h11615254990308360384
  │   10:        0x10f919238 - __rust_try
  │   11:        0x10f91633e - sys_common::unwind::try::inner_try::h819d2da8e3dc4516VKs
  │   12:        0x10e30e3da - boxed::_<impl>::call_box::call_box::h2288291939381523921
  │   13:        0x10f91b14d - sys::thread::_<impl>::new::thread_start::h328957c252b95d3cOYw
  │   14:     0x7fff91449059 - _pthread_body
  └   15:     0x7fff91448fd6 - _pthread_start
@KiChjang
Copy link
Member

KiChjang commented Dec 11, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2015

⌛ Testing commit eff54f3 with merge 99b9901...
bors-servo added a commit that referenced this pull request Dec 11, 2015
@bors-servo
Auto merge of #8923 - saneyuki:warning2, r=nox
Loading status checks…
99b9901 
Fix warning: Use iterator.min_by_key instead of iterator.min_by

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8923)
<!-- Reviewable:end -->
This was referenced Dec 11, 2015
Closed
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit eff54f3 into servo:master Dec 11, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@tetsuharuohzeki tetsuharuohzeki deleted the tetsuharuohzeki:warning2 branch Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@tetsuharuohzeki @highfive @nox @bors-servo @KiChjang
You can’t perform that action at this time.