Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPass around event types as Atoms instead of Strings #8930
Conversation
`Event` internally stores the `type` as an `Atom`, and we're `String`s everywhere, which can cause unnecessary allocations to occur since they'll end up as `Atom`s anyways.
|
Should the new initialization methods take |
|
Probably, but I'd rather make a separate issue for that |
|
@bors-servo r+ Looks ok to me, please file a follow-up issue for what @Ms2ger said. Reviewed 25 of 25 files at r1. Comments from the review on Reviewable.io |
|
|
Pass around event types as Atoms instead of Strings `Event` internally stores the `type` as an `Atom`, and we're `String`s everywhere, which can cause unnecessary allocations to occur since they'll end up as `Atom`s anyways. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8930) <!-- Reviewable:end -->
|
|
|
@bors-servo retry #8769 |
|
|
|
|
frewsxcv commentedDec 11, 2015
Eventinternally stores thetypeas anAtom, and we'reStringseverywhere, which can cause unnecessary allocations to occur since
they'll end up as
Atoms anyways.