Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the browsercontext module. #8942

Merged
merged 1 commit into from Dec 12, 2015
Merged

Rename the browsercontext module. #8942

merged 1 commit into from Dec 12, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 11, 2015

Review on Reviewable

@highfive
Copy link

highfive commented Dec 11, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@nox
Copy link
Member

nox commented Dec 11, 2015

@bors-servo rollup r+

@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2015

📌 Commit b7b5c79 has been approved by nox

@nox nox self-assigned this Dec 11, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2015

Testing commit b7b5c79 with merge ede495f...

bors-servo added a commit that referenced this pull request Dec 11, 2015
Rename the browsercontext module.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8942)
<!-- Reviewable:end -->
@jdm
Copy link
Member

jdm commented Dec 11, 2015

👏 👏

@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2015

💔 Test failed - linux-rel

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Dec 11, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2015

Testing commit b7b5c79 with merge 6b55155...

bors-servo added a commit that referenced this pull request Dec 11, 2015
Rename the browsercontext module.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8942)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2015

💔 Test failed - linux-rel

@KiChjang
Copy link
Member

KiChjang commented Dec 12, 2015


Ran 7097 tests finished in 372.0 seconds.
  • 7075 ran as expected. 8 tests skipped.
  • 22 tests timed out unexpectedly

Tests with unexpected results:
  ▶ TIMEOUT [expected PASS] /css21_dev/html4/display-014.htm

  ▶ TIMEOUT [expected FAIL] /css21_dev/html4/display-013.htm

  ▶ TIMEOUT [expected PASS] /css21_dev/html4/display-002.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  └ Shutting down the Constellation after generating an output file or exit flag specified

  ▶ TIMEOUT [expected PASS] /css21_dev/html4/display-001.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  └ Shutting down the Constellation after generating an output file or exit flag specified

  ▶ TIMEOUT [expected PASS] /css21_dev/html4/direction-applies-to-015.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  └ Shutting down the Constellation after generating an output file or exit flag specified

  ▶ TIMEOUT [expected PASS] /css21_dev/html4/direction-applies-to-014.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  └ Shutting down the Constellation after generating an output file or exit flag specified

  ▶ TIMEOUT [expected FAIL] /css21_dev/html4/direction-applies-to-006.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  │ Shutting down the Constellation after generating an output file or exit flag specified
  └ was ready to save, resetting ready_to_save_state

  ▶ TIMEOUT [expected FAIL] /css21_dev/html4/direction-applies-to-005.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  │ Shutting down the Constellation after generating an output file or exit flag specified
  └ was ready to save, resetting ready_to_save_state

  ▶ TIMEOUT [expected PASS] /css21_dev/html4/direction-applies-to-013.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  └ Shutting down the Constellation after generating an output file or exit flag specified

  ▶ TIMEOUT [expected FAIL] /css21_dev/html4/display-010.htm
  │ 
  └ was ready to save, resetting ready_to_save_state

  ▶ TIMEOUT [expected FAIL] /css21_dev/html4/direction-applies-to-008.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  │ Shutting down the Constellation after generating an output file or exit flag specified
  └ was ready to save, resetting ready_to_save_state

  ▶ TIMEOUT [expected PASS] /css21_dev/html4/display-015.htm

  ▶ TIMEOUT [expected PASS] /css21_dev/html4/display-011.htm
  │ 
  └ was ready to save, resetting ready_to_save_state

  ▶ TIMEOUT [expected PASS] /css21_dev/html4/display-006.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  │ Shutting down the Constellation after generating an output file or exit flag specified
  └ was ready to save, resetting ready_to_save_state

  ▶ TIMEOUT [expected PASS] /css21_dev/html4/display-016.htm

  ▶ TIMEOUT [expected PASS] /css21_dev/html4/display-008.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  └ Shutting down the Constellation after generating an output file or exit flag specified

  ▶ TIMEOUT [expected FAIL] /css21_dev/html4/display-007.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  └ Shutting down the Constellation after generating an output file or exit flag specified

  ▶ TIMEOUT [expected PASS] /css21_dev/html4/direction-applies-to-007.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  └ Shutting down the Constellation after generating an output file or exit flag specified

  ▶ TIMEOUT [expected FAIL] /css21_dev/html4/direction-applies-to-012.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  │ Shutting down the Constellation after generating an output file or exit flag specified
  └ was ready to save, resetting ready_to_save_state

  ▶ TIMEOUT [expected PASS] /css21_dev/html4/direction-applies-to-009.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  └ Shutting down the Constellation after generating an output file or exit flag specified

  ▶ TIMEOUT [expected FAIL] /css21_dev/html4/display-012.htm
  │ 
  └ was ready to save, resetting ready_to_save_state

  ▶ TIMEOUT [expected PASS] /css21_dev/html4/display-005.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  │ Shutting down the Constellation after generating an output file or exit flag specified
  └ was ready to save, resetting ready_to_save_state
@jdm
Copy link
Member

jdm commented Dec 12, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2015

Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-wpt are reusable. Rebuilding only linux-rel, mac-rel-css...

@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2015

💔 Test failed - mac-rel-css

@jdm
Copy link
Member

jdm commented Dec 12, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2015

Testing commit b7b5c79 with merge f4783a0...

bors-servo added a commit that referenced this pull request Dec 12, 2015
Rename the browsercontext module.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8942)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2015

@bors-servo bors-servo merged commit b7b5c79 into servo:master Dec 12, 2015
2 of 3 checks passed
2 of 3 checks passed
code-review/reviewable Review in progress: 0 of 4 files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:rename-bc branch Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.