Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove from Trusted::new an unnecessary argument #8949

Merged
merged 1 commit into from Dec 13, 2015
Merged

Remove from Trusted::new an unnecessary argument #8949

merged 1 commit into from Dec 13, 2015

Conversation

@askobara
Copy link
Contributor

askobara commented Dec 12, 2015

Fixes #8779

Review on Reviewable
@highfive
Copy link

highfive commented Dec 12, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.
@askobara
Remove from Trusted::new an unnecessary argument
Loading status checks…
8acb21a
@askobara askobara force-pushed the askobara:refactoring-trusted-new branch from 5e02955 to 8acb21a Dec 12, 2015
@askobara askobara changed the title Remove from Trusted::new a unnecessary argument Remove from Trusted::new an unnecessary argument Dec 12, 2015
@wafflespeanut
Copy link
Member

wafflespeanut commented Dec 12, 2015

@bors-servo try
1 similar comment
@frewsxcv
Copy link
Member

frewsxcv commented Dec 12, 2015

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2015

⌛ Trying commit 8acb21a with merge ceec87b...
bors-servo added a commit that referenced this pull request Dec 12, 2015
@bors-servo
Auto merge of #8949 - askobara:refactoring-trusted-new, r=<try>
ceec87b 
Remove from Trusted::new an unnecessary argument

Fixes #8779

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8949)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@jdm
Copy link
Member

jdm commented Dec 12, 2015

@bors-servo: r+
Thanks for making this improvement to the code!
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2015

📌 Commit 8acb21a has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2015

⌛ Testing commit 8acb21a with merge e493a06...
bors-servo added a commit that referenced this pull request Dec 12, 2015
@bors-servo
Auto merge of #8949 - askobara:refactoring-trusted-new, r=jdm
Loading status checks…
e493a06 
Remove from Trusted::new an unnecessary argument

Fixes #8779

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8949)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2015

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Dec 12, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2015

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 8acb21a into servo:master Dec 13, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@askobara @highfive @wafflespeanut @frewsxcv @bors-servo @jdm @SimonSapin
You can’t perform that action at this time.