Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DOMStringMap's stringifier behaviour according to the spec #8959

Merged
merged 1 commit into from Dec 18, 2015
Merged

Fix DOMStringMap's stringifier behaviour according to the spec #8959

merged 1 commit into from Dec 18, 2015

Conversation

@nox
Copy link
Member

nox commented Dec 13, 2015

It should just return its associated attribute's value, if any.

whatwg/dom#105

Review on Reviewable
@nox nox added the A-content/dom label Dec 13, 2015
@nox
Copy link
Member Author

nox commented Dec 13, 2015

Partially fixes #8511.
@frewsxcv
Copy link
Member

frewsxcv commented Dec 13, 2015

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2015

⌛ Trying commit 1e17a01 with merge e2018bf...
bors-servo added a commit that referenced this pull request Dec 13, 2015
@bors-servo
Auto merge of #8959 - nox:domtokenlist-stringifier, r=<try>
e2018bf 
Fix DOMStringMap's stringifier behaviour according to the spec

It should just return its associated attribute's value, if any.

whatwg/dom#105

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8959)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2015

💔 Test failed - mac-rel-css
@KiChjang
Copy link
Member

KiChjang commented Dec 13, 2015 

Ran 7097 tests finished in 884.0 seconds.
  • 7096 ran as expected. 8 tests skipped.
  • 1 tests crashed unexpectedly

Tests with unexpected results:
  ▶ CRASH [expected PASS] /css21_dev/html4/margin-bottom-064.htm
  │ 
  │ was ready to save, resetting ready_to_save_state
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ thread 'ScriptTask PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(0) }' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Custom(Custom { kind: Other, error: StringError("recursive IPC channel use during serialization") }) }', ../src/libcore/result.rs:741
  │ stack backtrace:
  │    1:        0x10d120ab8 - sys::backtrace::tracing::imp::write::hca66179add43b2e5lLt
  │    2:        0x10d122b7f - panicking::log_panic::_<closure>::closure.40842
  │    3:        0x10d122622 - panicking::log_panic::h7a04edac7e1f2797HEx
  │    4:        0x10d10e4c6 - sys_common::unwind::begin_unwind_inner::h39a94087039ae0efnOs
  │    5:        0x10d10e8ae - sys_common::unwind::begin_unwind_fmt::h7be0824d83765cd5tNs
  │    6:        0x10d1200d7 - rust_begin_unwind
  │    7:        0x10d145160 - panicking::panic_fmt::h871c0ef100fda9e9LFK
  │    8:        0x10c77be87 - mem::_<impl>::send::haf009788f0ee7115Bea
  │    9:        0x10c330640 - sys_common::unwind::try::try_fn::try_fn::h17387133094171496326
  │   10:        0x10d11fef8 - __rust_try
  │   11:        0x10d11cffe - sys_common::unwind::try::inner_try::h819d2da8e3dc4516VKs
  │   12:        0x10c331811 - boxed::_<impl>::call_box::call_box::h2443647416074846130
  │   13:        0x10d121e0d - sys::thread::_<impl>::new::thread_start::h328957c252b95d3cOYw
  │   14:     0x7fff8416a059 - _pthread_body
  │   15:     0x7fff84169fd6 - _pthread_start
  │ thread 'ScriptTask PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(0) }' panicked at 'called `Option::unwrap()` on a `None` value', ../src/libcore/option.rs:367
  │ stack backtrace:
  │    1:        0x10d120ab8 - sys::backtrace::tracing::imp::write::hca66179add43b2e5lLt
  │    2:        0x10d122b7f - panicking::log_panic::_<closure>::closure.40842
  │    3:        0x10d122622 - panicking::log_panic::h7a04edac7e1f2797HEx
  │    4:        0x10d10e3c4 - sys_common::unwind::begin_unwind_inner::h39a94087039ae0efnOs
  │    5:        0x10d10e8ae - sys_common::unwind::begin_unwind_fmt::h7be0824d83765cd5tNs
  │    6:        0x10d1200d7 - rust_begin_unwind
  │    7:        0x10d145160 - panicking::panic_fmt::h871c0ef100fda9e9LFK
  │    8:        0x10d14545c - panicking::panic::hbe2e3a5159c3d178iEK
  │    9:        0x10bee69d9 - page::_<impl>::window::he9494a240cfd38dfqqZ
  │   10:        0x10c32d714 - script_task::_<impl>::drop::h2beced7d2c679ffeiD0
  │   11:        0x10c331160 - sys_common::unwind::try::try_fn::try_fn::h17387133094171496326
  │   12:        0x10d11fef8 - __rust_try
  │   13:        0x10d11cffe - sys_common::unwind::try::inner_try::h819d2da8e3dc4516VKs
  │   14:        0x10c331811 - boxed::_<impl>::call_box::call_box::h2443647416074846130
  │   15:        0x10d121e0d - sys::thread::_<impl>::new::thread_start::h328957c252b95d3cOYw
  │   16:     0x7fff8416a059 - _pthread_body
  │   17:     0x7fff84169fd6 - _pthread_start
  └ thread panicked while panicking. aborting.
@nox
Copy link
Member Author

nox commented Dec 13, 2015

That's #8945.
@nox nox removed the S-tests-failed label Dec 13, 2015
@jdm
Copy link
Member

jdm commented Dec 13, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2015

⌛ Trying commit 1e17a01 with merge 59a8fde...
bors-servo added a commit that referenced this pull request Dec 13, 2015
@bors-servo
Auto merge of #8959 - nox:domtokenlist-stringifier, r=<try>
59a8fde 
Fix DOMStringMap's stringifier behaviour according to the spec

It should just return its associated attribute's value, if any.

whatwg/dom#105

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8959)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2015

💔 Test failed - mac-rel-wpt
@jdm
Copy link
Member

jdm commented Dec 13, 2015 

  ▶ Unexpected subtest result in /dom/nodes/Element-classlist.html:
  │ FAIL [expected PASS] empty classList should return the empty string since the ordered set parser skip the whitespaces
  │   → assert_equals: implicit expected "" but got " "
  │ 
  │ @http://web-platform.test:8000/dom/nodes/Element-classlist.html:54:3
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1381:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  └ @http://web-platform.test:8000/dom/nodes/Element-classlist.html:53:1
@nox nox force-pushed the nox:domtokenlist-stringifier branch from 1e17a01 to f676170 Dec 13, 2015
@nox
Copy link
Member Author

nox commented Dec 13, 2015

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2015

⌛ Trying commit f676170 with merge 678bab0...
bors-servo added a commit that referenced this pull request Dec 13, 2015
@bors-servo
Auto merge of #8959 - nox:domtokenlist-stringifier, r=<try>
678bab0 
Fix DOMStringMap's stringifier behaviour according to the spec

It should just return its associated attribute's value, if any.

whatwg/dom#105

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8959)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
components/script/dom/domtokenlist.rs Outdated
@@ -131,8 +131,7 @@ impl DOMTokenListMethods for DOMTokenList {

// https://dom.spec.whatwg.org/#stringification-behavior

This comment has been minimized.

Sign in to view
@Ms2ger

Ms2ger Dec 18, 2015

Contributor

Fix to https://dom.spec.whatwg.org/#dom-domtokenlist-stringifier or https://dom.spec.whatwg.org/#concept-dtl-serialize, please. r+ with that.

This comment has been minimized.

Sign in to view
@nox

nox Dec 18, 2015

Author Member

Good catch.
@nox
Fix DOMStringMap's stringifier behaviour according to the spec
Loading status checks…
e7a9f44 
It should just return its associated attribute's value, if any.

whatwg/dom#105
@nox nox force-pushed the nox:domtokenlist-stringifier branch from f676170 to e7a9f44 Dec 18, 2015
@nox
Copy link
Member Author

nox commented Dec 18, 2015

@bors-servo r=Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2015

📌 Commit e7a9f44 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2015

⌛ Testing commit e7a9f44 with merge 21277b1...
bors-servo added a commit that referenced this pull request Dec 18, 2015
@bors-servo
Auto merge of #8959 - nox:domtokenlist-stringifier, r=Ms2ger
Loading status checks…
21277b1 
Fix DOMStringMap's stringifier behaviour according to the spec

It should just return its associated attribute's value, if any.

whatwg/dom#105

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8959)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit e7a9f44 into servo:master Dec 18, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Dec 18, 2015
Closed
@nox nox deleted the nox:domtokenlist-stringifier branch Dec 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
A-content/dom S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@nox @frewsxcv @bors-servo @KiChjang @jdm @Ms2ger @highfive
You can’t perform that action at this time.