Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webgl: Make a general way to get data from a JS array buffer view #8970

Merged
merged 4 commits into from Jan 5, 2016
Merged

webgl: Make a general way to get data from a JS array buffer view #8970

merged 4 commits into from Jan 5, 2016

Commits on Jan 4, 2016

  1. webgl: Unify accessing ArrayBufferView objects 

    This fixes an invalid length being reported from
float32_array_to_slice (which used the byte length), and also to
generalize getting data from a JS array buffer view, to reduce code
duplication.

The pending type safety issues, like where we could send a UInt16Array
where we expect a Float32 one, should be solved by IDL bindings in
some cases, like uniform[n]fv or vertexAttrib[n]fv, and with extra
checks in others, like in the pending texImage2D(..., ArrayBufferView).
    @emilio
    emilio committed Jan 4, 2016
    Loading status checks…
    4d32444

  2. conversion: Extrapolate array_buffer_view_data 

    And use it instead of the raw jsapi calls.
    @emilio
    emilio committed Jan 4, 2016
    9ad49c8

  3. conversions: Add a checked version to array_buffer_view_data

    @emilio
    emilio committed Jan 4, 2016
    Loading status checks…
    43d395a

  4. conversions: Make a `is_type_compatible` method for ArrayBufferViews.

    @emilio
    emilio committed Jan 4, 2016
    Loading status checks…
    d30f055
You can’t perform that action at this time.