New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pinch zoom gesture for touch-screen devices #8975

Merged
merged 2 commits into from Dec 17, 2015

Conversation

Projects
None yet
4 participants
@mbrubeck
Contributor

mbrubeck commented Dec 14, 2015

r? @glennw

Notes:

  • Our layer system doesn't yet support zooming <iframe mozbrowser> separately, so this can only zoom the root window.
  • There are some issues that cause some tiles to disappear while zooming. I hope this will be fixed by WebRender.
  • Sorry this is mostly in one giant commit. I did the refactoring and adding new functionality in tandem, and didn't really end up with logical or compilable intermediate commits. Hopefully the new code is easier to read than the old stuff.

Review on Reviewable

@mbrubeck

This comment has been minimized.

Contributor

mbrubeck commented Dec 14, 2015

Also, if you're testing this on Android, you may want override android_glue to include tomaka/android-rs-glue#72

@glennw

This comment has been minimized.

Member

glennw commented Dec 16, 2015

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


components/compositing/touch.rs, line 153 [r1] (raw file):
touchend -> touchup


components/compositing/touch.rs, line 203 [r1] (raw file):
; isn't needed


Comments from the review on Reviewable.io

@glennw

This comment has been minimized.

Member

glennw commented Dec 16, 2015

@mbrubeck Couple of very minor nits, then r=me.

@mbrubeck mbrubeck force-pushed the mbrubeck:touch-refactor branch from b3970ad to 40776b9 Dec 16, 2015

@mbrubeck

This comment has been minimized.

Contributor

mbrubeck commented Dec 16, 2015

@bors-servo r=glennw


Review status: 2 of 3 files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Dec 16, 2015

📌 Commit 40776b9 has been approved by glennw

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Dec 17, 2015

⌛️ Testing commit 40776b9 with merge 0e4ae50...

bors-servo added a commit that referenced this pull request Dec 17, 2015

Auto merge of #8975 - mbrubeck:touch-refactor, r=glennw
Add pinch zoom gesture for touch-screen devices

r? @glennw

Notes:
* Our layer system doesn't yet support zooming `<iframe mozbrowser>` separately, so this can only zoom the root window.
* There are some issues that cause some tiles to disappear while zooming. I hope this will be fixed by WebRender.
* Sorry this is mostly in one giant commit. I did the refactoring and adding new functionality in tandem, and didn't really end up with logical or compilable intermediate commits. Hopefully the new code is easier to read than the old stuff.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8975)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Dec 17, 2015

@bors-servo bors-servo merged commit 40776b9 into servo:master Dec 17, 2015

2 of 3 checks passed

code-review/reviewable Review in progress: 2 of 3 files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@mbrubeck mbrubeck deleted the mbrubeck:touch-refactor branch May 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment