Various textinput fixes #8983

Manishearth · 2015-12-15T12:23:35Z

Currently the cursor sticks around if you click elsewhere. Now the text inputs are relayout-ed on blur.
Currently whitespace gets collapsed in text input (#8772). Not anymore.

highfive · 2015-12-15T12:23:38Z

Warning

These commits modify unsafe code. Please review it carefully!
These commits modify layout code, but no reftests are modified. Please consider adding a reftest!

Manishearth · 2015-12-15T12:45:58Z

r? @jdm

frewsxcv · 2015-12-15T12:47:54Z

Want to add the regression test from #8722?

Manishearth · 2015-12-15T12:51:31Z

Done

frewsxcv · 2015-12-15T13:00:42Z

Why not a WPT reftest?

Manishearth · 2015-12-15T13:02:17Z

Yeah, I'm working on that, after I get #8543 working too.

Manishearth · 2015-12-15T16:05:33Z

I added a reftest. It compares against things with   in their value (which used to work before). Let me know if I should add an image ref instead.

KiChjang · 2015-12-15T18:44:56Z

Travis CI fails to build right now.

$ bash etc/ci/manifest_changed.sh

diff --git a/tests/wpt/mozilla/meta/MANIFEST.json b/tests/wpt/mozilla/meta/MANIFEST.json

index 84262fa..7fccb08 100644

--- a/tests/wpt/mozilla/meta/MANIFEST.json

+++ b/tests/wpt/mozilla/meta/MANIFEST.json

@@ -2431,6 +2431,18 @@

             "url": "/_mozilla/css/input_whitespace.html"

           }

         ],

+        "css/input_whitespace_ref.html": [

+          {

+            "path": "css/input_whitespace_ref.html",

+            "references": [

+              [

+                "/_mozilla/css/input_whitespace_ref.html",

+                "=="

+              ]

+            ],

+            "url": "/_mozilla/css/input_whitespace_ref.html"

+          }

+        ],

         "css/inset.html": [

           {

             "path": "css/inset.html",

@@ -8316,6 +8328,18 @@

           "url": "/_mozilla/css/input_whitespace.html"

         }

       ],

+      "css/input_whitespace_ref.html": [

+        {

+          "path": "css/input_whitespace_ref.html",

+          "references": [

+            [

+              "/_mozilla/css/input_whitespace_ref.html",

+              "=="

+            ]

+          ],

+          "url": "/_mozilla/css/input_whitespace_ref.html"

+        }

+      ],

       "css/inset.html": [

         {

           "path": "css/inset.html",

The command "bash etc/ci/manifest_changed.sh" exited with 1.

Manishearth · 2015-12-16T02:58:39Z

I used create-wpt to create the test, and it added those changes. Not sure why they're failing.

Manishearth · 2015-12-16T03:06:24Z

Fixed.

bors-servo · 2015-12-31T20:19:46Z

☔ The latest upstream changes (presumably #9099) made this pull request unmergeable. Please resolve the merge conflicts.

Manishearth · 2016-01-02T15:25:23Z

Rebased.

bors-servo · 2016-01-03T05:32:30Z

☔ The latest upstream changes (presumably #9072) made this pull request unmergeable. Please resolve the merge conflicts.


        Relayout text input elements on blur


        Avoid whitespace collapse for text inputs (fixes #8772)


        Add frewscxv's regression test for whitespace in <input>


        Add reftest for whitespace in <input> and <textarea>

Manishearth · 2016-01-03T08:55:56Z

Rebased

Manishearth · 2016-01-07T08:08:26Z

Done

jdm · 2016-01-07T15:33:07Z

@bors-servo: r+

Reviewed 1 of 1 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

bors-servo · 2016-01-07T15:33:08Z

📌 Commit f67e208 has been approved by jdm

bors-servo · 2016-01-07T15:36:40Z

⌛ Testing commit f67e208 with merge 9d4cb85...


        Auto merge of #8983 - Manishearth:cursors, r=jdm

Various textinput fixes - Currently the cursor sticks around if you click elsewhere. Now the text inputs are relayout-ed on blur. - Currently whitespace gets collapsed in text input (#8772). Not anymore.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8983)

Manishearth · 2016-01-11T12:59:15Z

@bors retry force clean

Manishearth · 2016-01-11T12:59:55Z

@bors r=jdm retry try- force clean

KiChjang · 2016-01-11T13:00:27Z

@bors-servo retry force clean

Manishearth · 2016-01-11T13:00:49Z

@bors-servo r=jdm retry force clean

bors-servo · 2016-01-11T13:00:50Z

📌 Commit f67e208 has been approved by jdm

bors-servo · 2016-01-11T13:00:52Z

⌛ Testing commit f67e208 with merge 63251f1...


        Auto merge of #8983 - Manishearth:cursors, r=jdm

Various textinput fixes - Currently the cursor sticks around if you click elsewhere. Now the text inputs are relayout-ed on blur. - Currently whitespace gets collapsed in text input (#8772). Not anymore.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8983)

bors-servo · 2016-01-11T13:38:35Z

💔 Test failed - mac-rel-css

Manishearth · 2016-01-11T13:43:24Z

@bors-servo retry

bors-servo · 2016-01-11T16:11:23Z

💣 Failed to start rebuilding: 404 - No Such Resource

bors-servo · 2016-01-11T16:11:25Z

⌛ Testing commit f67e208 with merge dbc2c2f...


        Auto merge of #8983 - Manishearth:cursors, r=jdm

Various textinput fixes - Currently the cursor sticks around if you click elsewhere. Now the text inputs are relayout-ed on blur. - Currently whitespace gets collapsed in text input (#8772). Not anymore.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8983)

Manishearth · 2016-01-11T17:31:52Z

@bors retry clean

Manishearth · 2016-01-11T17:32:11Z

@bors-servo retry clean

bors-servo · 2016-01-11T17:51:04Z

⌛ Testing commit f67e208 with merge 099beee...


        Auto merge of #8983 - Manishearth:cursors, r=jdm

Various textinput fixes - Currently the cursor sticks around if you click elsewhere. Now the text inputs are relayout-ed on blur. - Currently whitespace gets collapsed in text input (#8772). Not anymore.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8983)

bors-servo · 2016-01-11T18:27:50Z

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

highfive added the S-awaiting-review label Dec 15, 2015

Manishearth changed the title ~~Relayout text input elements on blur~~ Various cursor fixes Dec 15, 2015

Manishearth changed the title ~~Various cursor fixes~~ Various textinput fixes Dec 15, 2015

highfive assigned jdm Dec 15, 2015

Manishearth mentioned this pull request Dec 15, 2015

Only display text caret in focused inputs #7757

Closed

Manishearth force-pushed the Manishearth:cursors branch from a4a4a18 to 98ce1c9 Dec 16, 2015

highfive added the S-needs-rebase label Dec 31, 2015

Manishearth force-pushed the Manishearth:cursors branch from 98ce1c9 to f1c3494 Jan 2, 2016

Manishearth removed the S-needs-rebase label Jan 2, 2016

highfive added the S-needs-rebase label Jan 3, 2016

Manishearth added 4 commits Dec 15, 2015

Relayout text input elements on blur

23e7dfa

Avoid whitespace collapse for text inputs (fixes #8772)

46a9c92

Add frewscxv's regression test for whitespace in <input>

77628df

Add reftest for whitespace in <input> and <textarea>

Loading status checks…

539ee18

Manishearth force-pushed the Manishearth:cursors branch from f1c3494 to 539ee18 Jan 3, 2016

jdm removed the S-awaiting-review label Jan 5, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Jan 7, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 11, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Jan 11, 2016

bors-servo merged commit f67e208 into servo:master Jan 11, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

Manishearth deleted the Manishearth:cursors branch Jan 11, 2016

servo / servo

Various textinput fixes #8983

Various textinput fixes #8983

Manishearth commented Dec 15, 2015

highfive commented Dec 15, 2015

Manishearth commented Dec 15, 2015

frewsxcv commented Dec 15, 2015

Manishearth commented Dec 15, 2015

frewsxcv commented Dec 15, 2015

Manishearth commented Dec 15, 2015

Manishearth commented Dec 15, 2015

KiChjang commented Dec 15, 2015

Manishearth commented Dec 16, 2015

Manishearth commented Dec 16, 2015

bors-servo commented Dec 31, 2015

Manishearth commented Jan 2, 2016

bors-servo commented Jan 3, 2016

Manishearth commented Jan 3, 2016

Manishearth commented Jan 7, 2016

jdm commented Jan 7, 2016

bors-servo commented Jan 7, 2016

bors-servo commented Jan 7, 2016

Manishearth commented Jan 11, 2016

Manishearth commented Jan 11, 2016

KiChjang commented Jan 11, 2016

Manishearth commented Jan 11, 2016

bors-servo commented Jan 11, 2016

bors-servo commented Jan 11, 2016

bors-servo commented Jan 11, 2016

Manishearth commented Jan 11, 2016

bors-servo commented Jan 11, 2016

bors-servo commented Jan 11, 2016

Manishearth commented Jan 11, 2016

Manishearth commented Jan 11, 2016

bors-servo commented Jan 11, 2016

bors-servo commented Jan 11, 2016

servo / servo

Join GitHub today

Various textinput fixes #8983

Various textinput fixes #8983

Conversation

Manishearth commented Dec 15, 2015

highfive commented Dec 15, 2015

Manishearth commented Dec 15, 2015

frewsxcv commented Dec 15, 2015

Manishearth commented Dec 15, 2015

frewsxcv commented Dec 15, 2015

Manishearth commented Dec 15, 2015

Manishearth commented Dec 15, 2015

KiChjang commented Dec 15, 2015

Manishearth commented Dec 16, 2015

Manishearth commented Dec 16, 2015

bors-servo commented Dec 31, 2015

Manishearth commented Jan 2, 2016

bors-servo commented Jan 3, 2016

Manishearth commented Jan 3, 2016

Manishearth commented Jan 7, 2016

jdm commented Jan 7, 2016

bors-servo commented Jan 7, 2016

bors-servo commented Jan 7, 2016

Manishearth commented Jan 11, 2016

Manishearth commented Jan 11, 2016

KiChjang commented Jan 11, 2016

Manishearth commented Jan 11, 2016

bors-servo commented Jan 11, 2016

bors-servo commented Jan 11, 2016

bors-servo commented Jan 11, 2016

Manishearth commented Jan 11, 2016

bors-servo commented Jan 11, 2016

bors-servo commented Jan 11, 2016

Manishearth commented Jan 11, 2016

Manishearth commented Jan 11, 2016

bors-servo commented Jan 11, 2016

bors-servo commented Jan 11, 2016