Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBump string_cache version to 0.2.5. #8992
Merged
Conversation
Atom::to_lower_case() now returns an Atom rather than a String, so there are a few asserts that need a different collection of &s and *s.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 15, 2015
Bump string_cache version to 0.2.5. Atom::to_lower_case() now returns an Atom rather than a String, so there are a few asserts that need a different collection of &s and *s. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8992) <!-- Reviewable:end -->
|
|
|
Which means this should have been 0.3.0, right? |
|
My read of rust-lang/rfcs#1105 is that this isn't a breaking change, since completely type-inferred code isn't affected. |
|
I tend towards the view that changes that can require downstream users to modify their code count as breaking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedDec 15, 2015
Atom::to_lower_case() now returns an Atom rather than a String,
so there are a few asserts that need a different collection of &s and *s.