Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylo uplifts Part 1 #9004

Merged
merged 3 commits into from Dec 23, 2015
Merged

Stylo uplifts Part 1 #9004

merged 3 commits into from Dec 23, 2015

Conversation

@bholley
Copy link
Contributor

bholley commented Dec 17, 2015

@pcwalton indicated his approval for landing stuff for the servo/gecko layout integration into the tree, which will improve maintainability for that effort. Here's an initial batch.

Review on Reviewable
@highfive
Copy link

highfive commented Dec 17, 2015

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
@bholley bholley force-pushed the bholley:stylo_uplifts_1 branch from 5d3a6c8 to eb48b5c Dec 17, 2015
@bholley
Copy link
Contributor Author

bholley commented Dec 17, 2015

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2015

⌛ Trying commit eb48b5c with merge 3e6bc2e...
bors-servo added a commit that referenced this pull request Dec 17, 2015
@bors-servo
Auto merge of #9004 - bholley:stylo_uplifts_1, r=<try>
3e6bc2e 
Stylo uplifts Part 1

@pcwalton indicated his approval for landing stuff for the servo/gecko layout integration into the tree, which will improve maintainability for that effort. Here's an initial batch.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9004)
<!-- Reviewable:end -->
@bholley bholley force-pushed the bholley:stylo_uplifts_1 branch from eb48b5c to 00e9764 Dec 17, 2015
@bholley
Copy link
Contributor Author

bholley commented Dec 17, 2015

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2015

⌛ Trying commit 00e9764 with merge 7002bee...
bors-servo added a commit that referenced this pull request Dec 17, 2015
@bors-servo
Auto merge of #9004 - bholley:stylo_uplifts_1, r=<try>
7002bee 
Stylo uplifts Part 1

@pcwalton indicated his approval for landing stuff for the servo/gecko layout integration into the tree, which will improve maintainability for that effort. Here's an initial batch.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9004)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bholley bholley force-pushed the bholley:stylo_uplifts_1 branch from 00e9764 to ded8392 Dec 18, 2015
@bholley
Copy link
Contributor Author

bholley commented Dec 18, 2015

I'm refactoring components/layout and moving parts of it to components/style, so I just removed the commit we discussed from this queue, and will include it in that refactoring.
@bholley
Copy link
Contributor Author

bholley commented Dec 18, 2015

r? @pcwalton on the rest
@bholley bholley force-pushed the bholley:stylo_uplifts_1 branch from ded8392 to dc95d76 Dec 22, 2015
@bholley bholley mentioned this pull request Dec 22, 2015
Merged
bors-servo added a commit that referenced this pull request Dec 22, 2015
@bors-servo
Auto merge of #9051 - bholley:split_style_and_layout_wrappers, r=<try>
a94e1df 
Split layout wrappers into style+layout and layout-only functionality

This is a step towards removing the dependency of stylo on layout/.

This PR depends on #9004.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9051)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Dec 23, 2015
@bors-servo
Auto merge of #9051 - bholley:split_style_and_layout_wrappers, r=<try>
dc924f7 
Split layout wrappers into style+layout and layout-only functionality

This is a step towards removing the dependency of stylo on layout/.

This PR depends on #9004.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9051)
<!-- Reviewable:end -->
@pcwalton
Copy link
Contributor

pcwalton commented Dec 23, 2015

Seems good to me.
bholley added 3 commits Dec 2, 2015
@bholley
Make DangerousThreadSafeLayoutNode public. :-(
6637626 
I'm open to suggestions on how to do this better.
@bholley
Add an is_text_node to LayoutNode, so that we don't need to implement…
e55a56d 
… type_id for the style system.
@bholley
Hoist more stuff from the concrete wrapper implementations into the t…
Loading status checks…
874545d 
…rait definitions to allow sharing.
@bholley bholley force-pushed the bholley:stylo_uplifts_1 branch from dc95d76 to 874545d Dec 23, 2015
@bholley
Copy link
Contributor Author

bholley commented Dec 23, 2015

r? @pcwalton
@jdm
Copy link
Member

jdm commented Dec 23, 2015

@bors-servo: r=pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2015

📌 Commit 874545d has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2015

⌛ Testing commit 874545d with merge 9412e71...
bors-servo added a commit that referenced this pull request Dec 23, 2015
@bors-servo
Auto merge of #9004 - bholley:stylo_uplifts_1, r=pcwalton
Loading status checks…
9412e71 
Stylo uplifts Part 1

@pcwalton indicated his approval for landing stuff for the servo/gecko layout integration into the tree, which will improve maintainability for that effort. Here's an initial batch.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9004)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2015

💔 Test failed - linux-rel
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Dec 23, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2015

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2015

💔 Test failed - linux-rel
@Manishearth
Copy link
Member

Manishearth commented Dec 23, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2015

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 874545d into servo:master Dec 23, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
bors-servo added a commit that referenced this pull request Dec 24, 2015
@bors-servo
Auto merge of #9051 - bholley:split_style_and_layout_wrappers, r=<try>
0f875c1 
Split layout wrappers into style+layout and layout-only functionality

This is a step towards removing the dependency of stylo on layout/.

This PR depends on #9004.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9051)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Dec 24, 2015
@bors-servo
Auto merge of #9051 - bholley:split_style_and_layout_wrappers, r=<try>
94c8165 
Split layout wrappers into style+layout and layout-only functionality

This is a step towards removing the dependency of stylo on layout/.

This PR depends on #9004.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9051)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Dec 24, 2015
@bors-servo
Auto merge of #9051 - bholley:split_style_and_layout_wrappers, r=<try>
0e1ad28 
Split layout wrappers into style+layout and layout-only functionality

This is a step towards removing the dependency of stylo on layout/.

This PR depends on #9004.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9051)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Dec 25, 2015
@bors-servo
Auto merge of #9051 - bholley:split_style_and_layout_wrappers, r=<try>
2a2f566 
Split layout wrappers into style+layout and layout-only functionality

This is a step towards removing the dependency of stylo on layout/.

This PR depends on #9004.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9051)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Dec 25, 2015
@bors-servo
Auto merge of #9051 - bholley:split_style_and_layout_wrappers, r=<try>
d0f4f03 
Split layout wrappers into style+layout and layout-only functionality

This is a step towards removing the dependency of stylo on layout/.

This PR depends on #9004.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9051)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Dec 25, 2015
@bors-servo
Auto merge of #9051 - bholley:split_style_and_layout_wrappers, r=<try>
2730690 
Split layout wrappers into style+layout and layout-only functionality

This is a step towards removing the dependency of stylo on layout/.

This PR depends on #9004.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9051)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Dec 30, 2015
@bors-servo
Auto merge of #9051 - bholley:split_style_and_layout_wrappers, r=Simo…
Loading status checks…
0f5c614 
…nSapin

Split layout wrappers into style+layout and layout-only functionality

This is a step towards removing the dependency of stylo on layout/.

This PR depends on #9004.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9051)
<!-- Reviewable:end -->
@bholley bholley deleted the bholley:stylo_uplifts_1 branch Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@bholley @highfive @bors-servo @pcwalton @jdm @larsbergstrom @Manishearth @SimonSapin
You can’t perform that action at this time.