Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PaintMsg enum to gfx_traits #8844 #9007

Closed
wants to merge 1 commit into from
Closed

Move PaintMsg enum to gfx_traits #8844 #9007

wants to merge 1 commit into from

Conversation

@mskrzypkows
Copy link

mskrzypkows commented Dec 17, 2015

Review on Reviewable
@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 17, 2015

Unfortunately, this conflicts with #8612, which has precedence. Could you rebase once that has landed?
@mskrzypkows
Copy link
Author

mskrzypkows commented Dec 17, 2015

OK, I'll wait for that patch.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2015

☔ The latest upstream changes (presumably #8612) made this pull request unmergeable. Please resolve the merge conflicts.
@mskrzypkows mskrzypkows force-pushed the mskrzypkows:PaintMsg_refactoring branch from 7e287a0 to 1f6a752 Dec 17, 2015
bors-servo added a commit that referenced this pull request Dec 17, 2015
@bors-servo
Auto merge of #9007 - mskrzypkows:PaintMsg_refactoring, r=jdm
16e7a6c 
Move PaintMsg enum to gfx_traits #8844

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9007)
<!-- Reviewable:end -->
@mskrzypkows
Copy link
Author

mskrzypkows commented Dec 17, 2015

It's strange, There was no check for PaintMsg::Ready and it compiled. Now there is error: components/compositing/constellation.rs:494:9: 698:10 error: non-exhaustive patterns: Paint(Ready(_)) not covered [E0004]
@jdm
Copy link
Member

jdm commented Dec 17, 2015

Looks like Ready doesn't exist on master: https://github.com/servo/servo/pull/9007/files#diff-8dc9268416cd4f037d50206e76c73cf9L247
@mskrzypkows
Copy link
Author

mskrzypkows commented Dec 17, 2015

Oh, that's right! Thanks
@mskrzypkows mskrzypkows force-pushed the mskrzypkows:PaintMsg_refactoring branch from 1f6a752 to 946d52c Dec 17, 2015
Maciej Skrzypkowski
Move PaintMsg enum to gfx_traits #8844
Loading status checks…
3f7f323
@mskrzypkows mskrzypkows force-pushed the mskrzypkows:PaintMsg_refactoring branch from 946d52c to 3f7f323 Dec 18, 2015
@mskrzypkows
Copy link
Author

mskrzypkows commented Dec 18, 2015

Corrected, please retry.
bors-servo added a commit that referenced this pull request Dec 18, 2015
@bors-servo
Auto merge of #9007 - mskrzypkows:PaintMsg_refactoring, r=jdm
71a0213 
Move PaintMsg enum to gfx_traits #8844

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9007)
<!-- Reviewable:end -->
@frewsxcv frewsxcv closed this Dec 18, 2015
@frewsxcv frewsxcv reopened this Dec 18, 2015
@KiChjang KiChjang closed this Dec 18, 2015
@KiChjang KiChjang reopened this Dec 18, 2015
@KiChjang KiChjang closed this Dec 18, 2015
@KiChjang KiChjang reopened this Dec 18, 2015
@KiChjang KiChjang closed this Dec 18, 2015
@KiChjang KiChjang reopened this Dec 18, 2015
@KiChjang KiChjang closed this Dec 18, 2015
@KiChjang KiChjang reopened this Dec 18, 2015
@KiChjang KiChjang closed this Dec 18, 2015
@KiChjang KiChjang reopened this Dec 18, 2015
@Manishearth Manishearth reopened this Dec 18, 2015
@Manishearth Manishearth mentioned this pull request Dec 18, 2015
Merged
@Manishearth
Copy link
Member

Manishearth commented Dec 18, 2015

moved to #9007
bors-servo added a commit that referenced this pull request Dec 18, 2015
@bors-servo
Auto merge of #9022 - mskrzypkows:PaintMsg_refactoring, r=jdm
41e2e6c 
Move PaintMsg enum to gfx_traits #8844

re-PR of #9007, because homu seems stuck

Fixes #8844.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9022)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Dec 19, 2015
@bors-servo
Auto merge of #9022 - mskrzypkows:PaintMsg_refactoring, r=jdm
Loading status checks…
95eabdb 
Move PaintMsg enum to gfx_traits #8844

re-PR of #9007, because homu seems stuck

Fixes #8844.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9022)
<!-- Reviewable:end -->
@mskrzypkows mskrzypkows deleted the mskrzypkows:PaintMsg_refactoring branch Dec 22, 2015
jrmuizel pushed a commit to jrmuizel/gecko-cinnabar that referenced this pull request Jun 12, 2017
Maciej Skrzypkowski
servo: Merge #9022 - Move PaintMsg enum to gfx_traits #8844 (from msk…
8e5e758 
…rzypkows:PaintMsg_refactoring); r=jdm

re-PR of servo/servo#9007, because homu seems stuck

Fixes #8844.

Source-Repo: https://github.com/servo/servo
Source-Revision: 95eabdb4dbdc00937eeea5b495002d5526217f93
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 1, 2019
@marco-c
servo: Merge #9022 - Move PaintMsg enum to gfx_traits #8844 (from msk…
14dc760 
…rzypkows:PaintMsg_refactoring); r=jdm

re-PR of servo/servo#9007, because homu seems stuck

Fixes #8844.

Source-Repo: https://github.com/servo/servo
Source-Revision: 95eabdb4dbdc00937eeea5b495002d5526217f93

UltraBlame original commit: 06fdb3bfdccb98108f5a24334a92ca9090fea798
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
@marco-c
servo: Merge #9022 - Move PaintMsg enum to gfx_traits #8844 (from msk…
2d0c54d 
…rzypkows:PaintMsg_refactoring); r=jdm

re-PR of servo/servo#9007, because homu seems stuck

Fixes #8844.

Source-Repo: https://github.com/servo/servo
Source-Revision: 95eabdb4dbdc00937eeea5b495002d5526217f93

UltraBlame original commit: 06fdb3bfdccb98108f5a24334a92ca9090fea798
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
@marco-c
servo: Merge #9022 - Move PaintMsg enum to gfx_traits #8844 (from msk…
d8d9423 
…rzypkows:PaintMsg_refactoring); r=jdm

re-PR of servo/servo#9007, because homu seems stuck

Fixes #8844.

Source-Repo: https://github.com/servo/servo
Source-Revision: 95eabdb4dbdc00937eeea5b495002d5526217f93

UltraBlame original commit: 06fdb3bfdccb98108f5a24334a92ca9090fea798
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@mskrzypkows @Ms2ger @bors-servo @jdm @Manishearth @frewsxcv @KiChjang @highfive
You can’t perform that action at this time.