Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More aggressively remove Fragment RestyleDamage #9008

Merged
merged 1 commit into from Jan 9, 2016

Conversation

@mrobinson
Copy link
Member

mrobinson commented Dec 17, 2015

Now clean up damage on all fragments that belong to a Flow. This ensures
that damage does not re-propagate up to the parent Flow from the
Fragments. It also means that the flow tree dump should show a more
accurate picture of the state of the flow tree.

Review on Reviewable

@highfive
Copy link

highfive commented Dec 17, 2015

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
@mrobinson
Copy link
Member Author

mrobinson commented Dec 17, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2015

The latest upstream changes (presumably #9044) made this pull request unmergeable. Please resolve the merge conflicts.

Now clean up damage on all fragments that belong to a Flow. This ensures
that damage does not re-propagate up to the parent Flow from the
Fragments. It also means that the flow tree dump should show a more
accurate picture of the state of the flow tree.
@mrobinson mrobinson force-pushed the mrobinson:reflow branch from 011cc45 to ce8e6fd Dec 23, 2015
@pcwalton
Copy link
Contributor

pcwalton commented Jan 8, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2016

📌 Commit ce8e6fd has been approved by pcwalton

@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2016

Testing commit ce8e6fd with merge cc3607f...

bors-servo added a commit that referenced this pull request Jan 8, 2016
More aggressively remove Fragment RestyleDamage

Now clean up damage on all fragments that belong to a Flow. This ensures
that damage does not re-propagate up to the parent Flow from the
Fragments. It also means that the flow tree dump should show a more
accurate picture of the state of the flow tree.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9008)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2016

💔 Test failed - linux-rel

@mrobinson
Copy link
Member Author

mrobinson commented Jan 8, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2016

Testing commit ce8e6fd with merge 87aecfe...

bors-servo added a commit that referenced this pull request Jan 9, 2016
More aggressively remove Fragment RestyleDamage

Now clean up damage on all fragments that belong to a Flow. This ensures
that damage does not re-propagate up to the parent Flow from the
Fragments. It also means that the flow tree dump should show a more
accurate picture of the state of the flow tree.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9008)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2016

💔 Test failed - linux-rel

@mrobinson
Copy link
Member Author

mrobinson commented Jan 9, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2016

Testing commit ce8e6fd with merge 1436ee5...

bors-servo added a commit that referenced this pull request Jan 9, 2016
More aggressively remove Fragment RestyleDamage

Now clean up damage on all fragments that belong to a Flow. This ensures
that damage does not re-propagate up to the parent Flow from the
Fragments. It also means that the flow tree dump should show a more
accurate picture of the state of the flow tree.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9008)
<!-- Reviewable:end -->
@highfive highfive removed the S-tests-failed label Jan 9, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2016

@bors-servo bors-servo merged commit ce8e6fd into servo:master Jan 9, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mrobinson mrobinson deleted the mrobinson:reflow branch Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.