Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a valgrind suppression file. #9011

Merged
merged 1 commit into from Dec 18, 2015

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Dec 17, 2015

Adding a suppression file reduces the number of false positives from memcheck. Run with:

valgrind --suppressions=etc/valgrind-memcheck.supp servo ...

For the moment, this just switches off the warnings generated by jemalloc.

Review on Reviewable

Adding a suppression file reduces the number of false positives from memcheck. Run with:
```
valgrind --suppressions=etc/valgrind-memcheck.supp servo ...
```
For the moment, this just switches off the warnings generated by jemalloc.
@metajack
Copy link
Contributor

metajack commented Dec 17, 2015

@bors-servo r+


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2015

📌 Commit 5ca06b5 has been approved by metajack

@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2015

Testing commit 5ca06b5 with merge f3e921a...

bors-servo added a commit that referenced this pull request Dec 18, 2015
…ajack

Add a valgrind suppression file.

Adding a suppression file reduces the number of false positives from memcheck. Run with:
```
valgrind --suppressions=etc/valgrind-memcheck.supp servo ...
```
For the moment, this just switches off the warnings generated by jemalloc.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9011)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2015

💔 Test failed - linux-rel

@frewsxcv
Copy link
Member

frewsxcv commented Dec 18, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2015

Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...

@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2015

@bors-servo bors-servo merged commit 5ca06b5 into servo:master Dec 18, 2015
3 checks passed
3 checks passed
code-review/reviewable Review complete: all files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.