Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Debug for FontGroup and Homu is a bully #9013

Merged
merged 2 commits into from Dec 18, 2015
Merged

Derive Debug for FontGroup and Homu is a bully #9013

merged 2 commits into from Dec 18, 2015

Conversation

@nox
Copy link
Member

nox commented Dec 17, 2015

#8908 is @bors-servo's unlucky number, it seems.

Review on Reviewable
antrik added 2 commits Dec 9, 2015
@antrik
HashCache: Apply trait bounds on type itself, rather than only the impl
3d078f7 
I don't think there is any reason to keep the container more generic
than its (only) implementation -- the constraints are necessary for this
container to work at all.

Defining the constraints on the type itself also enables use
of #[derive(Debug)].
@antrik
Derive Debug on FontGroup and its components
Loading status checks…
c5ede58
@nox
Copy link
Member Author

nox commented Dec 17, 2015

@bors-servo r=Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2015

📌 Commit c5ede58 has been approved by Ms2ger
@nox
Copy link
Member Author

nox commented Dec 17, 2015

@antrik Thank you for your work, sorry for our excuse of a continuous integration this time. :(
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2015

⌛ Testing commit c5ede58 with merge bd4a150...
bors-servo added a commit that referenced this pull request Dec 18, 2015
@bors-servo
Auto merge of #9013 - antrik:debug-fontgroup, r=Ms2ger
bd4a150 
Derive Debug for FontGroup and Homu is a bully

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9013)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2015

💔 Test failed - mac-rel-wpt
@antrik
Copy link
Contributor

antrik commented Dec 18, 2015

And back to where we started :-(

By the looks of it, it's the same -- or similar -- problem it run into on the first try (in the original issue) with the latest code. (Is there a way to get at the old log to make sure?) But it's just coincidence that it triggered the same intermittent issue, right?...
@KiChjang
Copy link
Member

KiChjang commented Dec 18, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2015

⌛ Testing commit c5ede58 with merge 381e707...
bors-servo added a commit that referenced this pull request Dec 18, 2015
@bors-servo
Auto merge of #9013 - antrik:debug-fontgroup, r=Ms2ger
381e707 
Derive Debug for FontGroup and Homu is a bully

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9013)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2015

💔 Test failed - linux-rel
@antrik
Copy link
Contributor

antrik commented Dec 18, 2015

This is getting surreal. The original PR also failed linux-rel on the retry. WTF?

(I found the old logs BTW. It's not the exact same test failing -- but very close by.)
@KiChjang
Copy link
Member

KiChjang commented Dec 18, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2015

⌛ Testing commit c5ede58 with merge 6490d1e...
bors-servo added a commit that referenced this pull request Dec 18, 2015
@bors-servo
Auto merge of #9013 - antrik:debug-fontgroup, r=Ms2ger
Loading status checks…
6490d1e 
Derive Debug for FontGroup and Homu is a bully

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9013)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit c5ede58 into servo:master Dec 18, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @bors-servo @antrik @KiChjang @Ms2ger @highfive
You can’t perform that action at this time.