New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update `mach run` to use android_params file #9020

Merged
merged 1 commit into from Dec 18, 2015

Conversation

Projects
None yet
4 participants
@mbrubeck
Contributor

mbrubeck commented Dec 18, 2015

Currently it sets the SERVO_URL variable, which Servo no longer supports.

r? @larsbergstrom

Review on Reviewable

@larsbergstrom

This comment has been minimized.

Contributor

larsbergstrom commented Dec 18, 2015

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Dec 18, 2015

📌 Commit d7ba536 has been approved by larsbergstrom

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Dec 18, 2015

⌛️ Testing commit d7ba536 with merge 27998f7...

bors-servo added a commit that referenced this pull request Dec 18, 2015

Auto merge of #9020 - mbrubeck:mach-run, r=larsbergstrom
Update `mach run` to use android_params file

Currently it sets the SERVO_URL variable, which Servo no longer supports.

r? @larsbergstrom

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9020)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Dec 18, 2015

⌛️ Testing commit d7ba536 with merge 2a3a7a7...

bors-servo added a commit that referenced this pull request Dec 18, 2015

Auto merge of #9020 - mbrubeck:mach-run, r=larsbergstrom
Update `mach run` to use android_params file

Currently it sets the SERVO_URL variable, which Servo no longer supports.

r? @larsbergstrom

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9020)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Dec 18, 2015

@bors-servo bors-servo merged commit d7ba536 into servo:master Dec 18, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@mbrubeck mbrubeck deleted the mbrubeck:mach-run branch May 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment