Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTrinity College Dublin Image Conformance Project (N.B not fully complete yet) #9021
Conversation
Added the readonly currentSrc attribute to HTMLImageElement.webidl and implemented the CurrentSrc getter in HTMLImageElement.rs
Added the crossOrigin attribute to HTMLImageElement.webidl and a make_setter and make_getter for crossOrigin to HTMLImageElement.rs
Trinity College Task 1 (Update htmlimagerequest.rs)
Trinity College Dublin Image Conformance 2nd Task (Add crossOrigin attribute to HTMLImageElement.webidl)
Merged Trinity College Dublin image conformance project 3rd task (Add currentSrc attribute to HTMLImageElement.webidl)
Merged Trinity College Dublin's Image Conformance project (4th task). add a command for the image cache task that accepts a URL and a vector of bytes. This command should instruct the cache to store this data as a newly-complete network request and continue decoding the result into pixel data.
highfive
commented
Dec 18, 2015
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon. |
paterson
changed the title
|
Hi @paterson! Did my reply on Dec 10 help with the scenario you mention? |
|
@paterson Ping? |
|
|
Closed
|
Rebased as #9480. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paterson commentedDec 18, 2015
Hi there!
We're the group behind this feature:
https://github.com/servo/servo/wiki/Image-load-conformance-student-project
We've completed the initial tasks as outlined above, except for one issue with conformance with JSTrace, HeapSizeOf etc. We've outlined the scenario here:
https://groups.google.com/forum/#!topic/mozilla.dev.servo/HvgCJ9-ozns
We may complete the project after Christmas on our own accord, but we just needed to have a pull request submitted as part of our college module, so this is why we are submitting this now. It is not ready for consideration quite yet. We will update this pull request with any further progress.
Thanks!