Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

touchlist dom api #8225 #9025

Merged
merged 1 commit into from Dec 20, 2015
Merged

touchlist dom api #8225 #9025

merged 1 commit into from Dec 20, 2015

Conversation

@k-cross
Copy link
Contributor

k-cross commented Dec 19, 2015

Sorry for the wait, I just finished my finals.

Fixes #8225

Review on Reviewable
@highfive
Copy link

highfive commented Dec 19, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.
@nox nox self-assigned this Dec 19, 2015
@nox
Copy link
Member

nox commented Dec 19, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 19, 2015

📌 Commit 0556013 has been approved by nox
@nox
Copy link
Member

nox commented Dec 19, 2015

@bors-servo r- force

Actually sorry, the spec link is wrong, it should be https://w3c.github.io/touch-events/#idl-def-document-createtouchlist(touch...).
k-cross
touchlist dom api #8225
Loading status checks…
ae8d3f6
@k-cross k-cross force-pushed the k-cross:master branch from 0556013 to ae8d3f6 Dec 19, 2015
@nox
Copy link
Member

nox commented Dec 20, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2015

📌 Commit ae8d3f6 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2015

⌛ Testing commit ae8d3f6 with merge f9d8ed3...
bors-servo added a commit that referenced this pull request Dec 20, 2015
@bors-servo
Auto merge of #9025 - k-cross:master, r=nox
f9d8ed3 
touchlist dom api #8225

Sorry for the wait, I just finished my finals.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9025)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2015

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Dec 20, 2015 


Ran 3736 tests finished in 209.0 seconds.
  • 3735 ran as expected. 709 tests skipped.
  • 1 tests failed unexpectedly

Tests with unexpected results:
  ▶ FAIL [expected PASS] /_mozilla/css/abs-overflow-stackingcontext.html
  └   → /_mozilla/css/abs-overflow-stackingcontext.html d9d9e489bc5b4508c01b06c7ff92f19dcc2ece3c
/_mozilla/css/abs-overflow-stackingcontext_ref.html 38ce16767330b708ec4459a742a7122c37307f64
Testing d9d9e489bc5b4508c01b06c7ff92f19dcc2ece3c == 38ce16767330b708ec4459a742a7122c37307f64
@KiChjang KiChjang mentioned this pull request Dec 20, 2015
Closed
@nox nox mentioned this pull request Dec 20, 2015
Open
@nox
Copy link
Member

nox commented Dec 20, 2015

@bors-servo retry #9033
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2015

⚡ Previous build results for android, gonk, mac-dev-ref-unit are reusable. Rebuilding only linux-dev, linux-rel, mac-rel-css, mac-rel-wpt...
@nox nox added S-awaiting-merge and removed S-tests-failed labels Dec 20, 2015
@frewsxcv
Copy link
Member

frewsxcv commented Dec 20, 2015

@bors-servo retry clean
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2015

⌛ Testing commit ae8d3f6 with merge e1cecb2...
bors-servo added a commit that referenced this pull request Dec 20, 2015
@bors-servo
Auto merge of #9025 - k-cross:master, r=nox
e1cecb2 
touchlist dom api #8225

Sorry for the wait, I just finished my finals.

Fixes #8225

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9025)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2015

💔 Test failed - linux-rel
@frewsxcv
Copy link
Member

frewsxcv commented Dec 20, 2015

@bors-servo retry #8157
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2015

⌛ Testing commit ae8d3f6 with merge 5b91daa...
bors-servo added a commit that referenced this pull request Dec 20, 2015
@bors-servo
Auto merge of #9025 - k-cross:master, r=nox
Loading status checks…
5b91daa 
touchlist dom api #8225

Sorry for the wait, I just finished my finals.

Fixes #8225

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9025)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit ae8d3f6 into servo:master Dec 20, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@k-cross @highfive @nox @bors-servo @KiChjang @frewsxcv
You can’t perform that action at this time.