Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EventSource and update test expectations #9029

Merged
merged 1 commit into from Jan 6, 2016
Merged

Implement EventSource and update test expectations #9029

merged 1 commit into from Jan 6, 2016

Conversation

@KiChjang
Copy link
Member

KiChjang commented Dec 20, 2015

Partial #8925.

Most of the processing model for EventSource are unimplemented because we currently don't have a fetch implementation.

Review on Reviewable
bors-servo added a commit that referenced this pull request Dec 20, 2015
@bors-servo
Auto merge of #9029 - KiChjang:event-source, r=<try>
1b2f3b2 
Implement EventSource and update test expectations

Partial #8925.

Most of the processing model for `EventSource` are unimplemented because we currently don't have a fetch implementation.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9029)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2015

💔 Test failed - gonk
@KiChjang KiChjang force-pushed the KiChjang:event-source branch from 1495fca to 72ccdb0 Dec 20, 2015
bors-servo added a commit that referenced this pull request Dec 20, 2015
@bors-servo
Auto merge of #9029 - KiChjang:event-source, r=<try>
fb11a18 
Implement EventSource and update test expectations

Partial #8925.

Most of the processing model for `EventSource` are unimplemented because we currently don't have a fetch implementation.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9029)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2015

💔 Test failed - linux-dev
@KiChjang KiChjang force-pushed the KiChjang:event-source branch from 72ccdb0 to 6c430bc Dec 20, 2015
bors-servo added a commit that referenced this pull request Dec 20, 2015
@bors-servo
Auto merge of #9029 - KiChjang:event-source, r=<try>
e31e0a3 
Implement EventSource and update test expectations

Partial #8925.

Most of the processing model for `EventSource` are unimplemented because we currently don't have a fetch implementation.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9029)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2015

💔 Test failed - mac-rel-wpt
@KiChjang KiChjang force-pushed the KiChjang:event-source branch from 6c430bc to fa18b1f Dec 20, 2015
@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 20, 2015

Making script depend on net will make @jdm sad.
@KiChjang KiChjang force-pushed the KiChjang:event-source branch from fa18b1f to 424411f Dec 20, 2015
bors-servo added a commit that referenced this pull request Dec 20, 2015
@bors-servo
Auto merge of #9029 - KiChjang:event-source, r=<try>
0790307 
Implement EventSource and update test expectations

Partial #8925.

Most of the processing model for `EventSource` are unimplemented because we currently don't have a fetch implementation.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9029)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2015

💔 Test failed - gonk
@KiChjang KiChjang force-pushed the KiChjang:event-source branch from 424411f to c0aa513 Dec 20, 2015
@KiChjang
Copy link
Member Author

KiChjang commented Dec 20, 2015

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2015

⌛ Trying commit c0aa513 with merge edf1889...
bors-servo added a commit that referenced this pull request Dec 20, 2015
@bors-servo
Auto merge of #9029 - KiChjang:event-source, r=<try>
edf1889 
Implement EventSource and update test expectations

Partial #8925.

Most of the processing model for `EventSource` are unimplemented because we currently don't have a fetch implementation.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9029)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2015

💔 Test failed - linux-rel
@KiChjang
Copy link
Member Author

KiChjang commented Dec 20, 2015

r? @jdm
@jdm
Copy link
Member

jdm commented Jan 6, 2016

-S-awaiting-review +S-needs-code-changes

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

Comments from the review on Reviewable.io
@KiChjang KiChjang force-pushed the KiChjang:event-source branch from da1d641 to 5ece3ce Jan 6, 2016
@KiChjang
Implement EventSource and update test expectations
Loading status checks…
1d62db4
@KiChjang KiChjang force-pushed the KiChjang:event-source branch from 5ece3ce to 1d62db4 Jan 6, 2016
@jdm
Copy link
Member

jdm commented Jan 6, 2016

@bors-servo: r+

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

📌 Commit 1d62db4 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

⌛ Testing commit 1d62db4 with merge 37944e7...
bors-servo added a commit that referenced this pull request Jan 6, 2016
@bors-servo
Auto merge of #9029 - KiChjang:event-source, r=jdm
37944e7 
Implement EventSource and update test expectations

Partial #8925.

Most of the processing model for `EventSource` are unimplemented because we currently don't have a fetch implementation.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9029)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Jan 6, 2016

@bors-servo: retry

  • presumably someone was running tests on the builder
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

⌛ Testing commit 1d62db4 with merge 238a878...
bors-servo added a commit that referenced this pull request Jan 6, 2016
@bors-servo
Auto merge of #9029 - KiChjang:event-source, r=jdm
Loading status checks…
238a878 
Implement EventSource and update test expectations

Partial #8925.

Most of the processing model for `EventSource` are unimplemented because we currently don't have a fetch implementation.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9029)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Jan 6, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

⚡ Previous build results for android, gonk, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-dev, linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 1d62db4 into servo:master Jan 6, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jan 6, 2016
Merged
@KiChjang KiChjang deleted the KiChjang:event-source branch May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@KiChjang @bors-servo @Ms2ger @jdm @SimonSapin @highfive
You can’t perform that action at this time.