Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Document charset #9036

Merged
merged 1 commit into from Dec 21, 2015
Merged

Implement Document charset #9036

merged 1 commit into from Dec 21, 2015

Conversation

@KiChjang
Copy link
Member

KiChjang commented Dec 20, 2015

Rebase of #7966.

Fixes #7718.

Review on Reviewable
@KiChjang KiChjang mentioned this pull request Dec 20, 2015
Closed
@KiChjang
Copy link
Member Author

KiChjang commented Dec 20, 2015

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2015

⌛ Trying commit e752c42 with merge 0a1e1c5...
bors-servo added a commit that referenced this pull request Dec 20, 2015
@bors-servo
Auto merge of #9036 - KiChjang:document-charset, r=<try>
0a1e1c5 
Implement Document charset

Rebase of #7966.

Fixes #7718.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9036)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2015

💔 Test failed - linux-dev
@KiChjang
Copy link
Member Author

KiChjang commented Dec 20, 2015

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2015

⌛ Trying commit be09b1e with merge ff6a922...
bors-servo added a commit that referenced this pull request Dec 20, 2015
@bors-servo
Auto merge of #9036 - KiChjang:document-charset, r=<try>
ff6a922 
Implement Document charset

Rebase of #7966.

Fixes #7718.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9036)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@KiChjang KiChjang force-pushed the KiChjang:document-charset branch from be09b1e to a8c7996 Dec 20, 2015
@KiChjang
Copy link
Member Author

KiChjang commented Dec 20, 2015

r? @Ms2ger
@vectorijk
Copy link
Contributor

vectorijk commented Dec 20, 2015

lgtm @KiChjang
@KiChjang KiChjang closed this Dec 21, 2015
@KiChjang KiChjang reopened this Dec 21, 2015
@nox
Copy link
Member

nox commented Dec 21, 2015

You should squash the two commits, but I can understand keeping them separate if you want to keep the creds.
@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 21, 2015

This is okay, but please do squash.
@KiChjang KiChjang force-pushed the KiChjang:document-charset branch from a8c7996 to c559270 Dec 21, 2015
@KiChjang
Copy link
Member Author

KiChjang commented Dec 21, 2015

r? @Ms2ger
@vectorijk @KiChjang
implement document charset
Loading status checks…
c559270 
- pre-compute the adjusted encoding name

Fix build errors and update test expectations
@jdm
Copy link
Member

jdm commented Dec 21, 2015

@bors-servo r=Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Dec 21, 2015

📌 Commit c559270 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Dec 21, 2015

⌛ Testing commit c559270 with merge df087cc...
bors-servo added a commit that referenced this pull request Dec 21, 2015
@bors-servo
Auto merge of #9036 - KiChjang:document-charset, r=Ms2ger
Loading status checks…
df087cc 
Implement Document charset

Rebase of #7966.

Fixes #7718.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9036)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 21, 2015

💔 Test failed - linux-rel
@KiChjang
Copy link
Member Author

KiChjang commented Dec 21, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 21, 2015

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 21, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit c559270 into servo:master Dec 21, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@KiChjang KiChjang deleted the KiChjang:document-charset branch Dec 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@KiChjang @bors-servo @vectorijk @nox @Ms2ger @jdm @SimonSapin @highfive
You can’t perform that action at this time.