Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse DisplayListSection everywhere #9059
Merged
Conversation
highfive
commented
Dec 23, 2015
|
|
|
r? @pcwalton |
|
|
DisplayListSection, StackingLevel, and BackgroundAndBorderLevel all represent pretty much the same thing, a particular section of the display list. Instead of maintaining three enums which do the same thing, just use DisplayListSection everywhere. It's a superset of the other two and this change will make it easier to flatten the DisplayList in the future for WebRender.
mrobinson
force-pushed the
mrobinson:simplify-display-list-sections
branch
from
f920884
to
d720452
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 8, 2016
…alton Use DisplayListSection everywhere DisplayListSection, StackingLevel, and BackgroundAndBorderLevel all represent pretty much the same thing, a particular section of the display list. Instead of maintaining three enums which do the same thing, just use DisplayListSection everywhere. It's a superset of the other two and this change will make it easier to flatten the DisplayList in the future for WebRender. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9059) <!-- Reviewable:end -->
|
|
|
@bors-servo retry #8769 |
bors-servo
added a commit
that referenced
this pull request
Jan 9, 2016
…alton Use DisplayListSection everywhere DisplayListSection, StackingLevel, and BackgroundAndBorderLevel all represent pretty much the same thing, a particular section of the display list. Instead of maintaining three enums which do the same thing, just use DisplayListSection everywhere. It's a superset of the other two and this change will make it easier to flatten the DisplayList in the future for WebRender. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9059) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedDec 23, 2015
DisplayListSection, StackingLevel, and BackgroundAndBorderLevel all
represent pretty much the same thing, a particular section of the
display list. Instead of maintaining three enums which do the same
thing, just use DisplayListSection everywhere. It's a superset of the
other two and this change will make it easier to flatten the DisplayList
in the future for WebRender.