Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHACKING_QUICKSTART.md: Don't recommend creating .cargo/config in pare… #9069
Conversation
…nt directory Recommend putting crate overrides directly in the servo/.cargo/config, rather than in Servo's parent directory. Overrides in the parent directory are unnecessary and confusing for typical use cases.
|
Thanks! @bors-servo r+ |
|
@bors-servo r=SimonSapin rollup |
|
@bors-servo r=SimonSapin rollup |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 25, 2015
HACKING_QUICKSTART.md: Don't recommend creating .cargo/config in pare… …nt directory Recommend putting crate overrides directly in the servo/.cargo/config, rather than in Servo's parent directory. Overrides in the parent directory are unnecessary and confusing for typical use cases. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9069) <!-- Reviewable:end -->
|
|
|
Yay, documentation tweak broke CSS tests!... Intermittent failures make CI kinda surrealistic ;-) |
|
@bors-servo retry #9071 |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
antrik commentedDec 25, 2015
…nt directory
Recommend putting crate overrides directly in the servo/.cargo/config,
rather than in Servo's parent directory.
Overrides in the parent directory are unnecessary and confusing for
typical use cases.