Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Debug for more font-related types #9070

Merged
merged 3 commits into from Jan 3, 2016
Merged

Derive Debug for more font-related types #9070

merged 3 commits into from Jan 3, 2016

Conversation

@antrik
Copy link
Contributor

antrik commented Dec 26, 2015

Needs to pull in newer ipc-channel and azure.

Review on Reviewable
@nox nox self-assigned this Dec 26, 2015
@nox
Copy link
Member

nox commented Dec 26, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 26, 2015

📌 Commit 8b7d807 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Dec 26, 2015

⌛ Testing commit 8b7d807 with merge 221f3a5...
bors-servo added a commit that referenced this pull request Dec 26, 2015
@bors-servo
Auto merge of #9070 - antrik:debug-fonts, r=nox
221f3a5 
Derive Debug for more font-related types

Needs to pull in newer ipc-channel and azure.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9070)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 26, 2015

💔 Test failed - gonk
@nox
Copy link
Member

nox commented Dec 26, 2015

@antrik What do you use to update the Cargo files? Did you properly use ./mach update-cargo?
@antrik
Copy link
Contributor Author

antrik commented Dec 26, 2015

So it turns out I broke ipc-message for all platforms using the "inprocess" backend (target_os="android", target_os="windows") with servo/ipc-channel#21, and apparently there is no CI for that... This is rather unsettling.
@nox
Copy link
Member

nox commented Dec 26, 2015

Cc @larsbergstrom @metajack.
@antrik
Copy link
Contributor Author

antrik commented Dec 26, 2015

I submitted a fix for ipc-message: servo/ipc-channel#22

I can update this PR once the ipc-message one is in.
@nox
Copy link
Member

nox commented Jan 2, 2016

Could you update it?
antrik added 3 commits Dec 25, 2015
@antrik
cargo-update ipc-channel to get <Debug>
61149b3
@antrik
cargo-update azure to get <Debug>
7197e7f
@antrik
Derive Debug for more font-related types
Loading status checks…
3c5a3ca
@antrik antrik force-pushed the antrik:debug-fonts branch from 8b7d807 to 3c5a3ca Jan 3, 2016
@antrik
Copy link
Contributor Author

antrik commented Jan 3, 2016

I got somewhat uncertain after I realised that for some types -- such as FontTemplateData -- deriving Debug is useless, as it will print the entire blob. However, I checked now that it affects only my other PR (which has already been merged, and will thus need a follow-up), but not this one.

Updated now for the fixed ipc-message.
@nox
Copy link
Member

nox commented Jan 3, 2016

@bors-servo r+

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Jan 3, 2016

📌 Commit 3c5a3ca has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Jan 3, 2016

⌛ Testing commit 3c5a3ca with merge ebf4ce8...
bors-servo added a commit that referenced this pull request Jan 3, 2016
@bors-servo
Auto merge of #9070 - antrik:debug-fonts, r=nox
Loading status checks…
ebf4ce8 
Derive Debug for more font-related types

Needs to pull in newer ipc-channel and azure.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9070)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 3, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 3c5a3ca into servo:master Jan 3, 2016
3 checks passed
3 checks passed
code-review/reviewable Review complete: all files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@antrik @nox @bors-servo @highfive
You can’t perform that action at this time.