Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault caused by document wrapper being GCed. #908

Merged
merged 2 commits into from Sep 11, 2013
Merged

Conversation

@jdm
Copy link
Member

jdm commented Sep 11, 2013

No description provided.

@metajack

This comment has been minimized.

Copy link

metajack commented on 9640324 Sep 11, 2013

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 9640324 Sep 11, 2013

saw approval from metajack
at jdm@9640324

This comment has been minimized.

Copy link
Contributor

bors-servo replied Sep 11, 2013

merging jdm/servo/sandbox = 9640324 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Sep 11, 2013

jdm/servo/sandbox = 9640324 merged ok, testing candidate = 39252b2

This comment has been minimized.

Copy link
Contributor

bors-servo replied Sep 11, 2013

fast-forwarding master to auto = 39252b2

This comment has been minimized.

Copy link

DavidBruant replied Sep 13, 2013

One of the most important game changer for web developers. This almost makes effectively WebWorkers useless.
Canvas rendering can now be done in parallel without resort to new (arguably awkward) API (just open a sandboxed iframe and render there)

<3 that is all. Thanks @jdm and @bors-servo !

@jdm
Copy link
Member Author

jdm commented Sep 11, 2013

This requires servo/rust-mozjs#36.

@metajack

This comment has been minimized.

Copy link

metajack commented on 636c30a Sep 11, 2013

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 636c30a Sep 11, 2013

saw approval from metajack
at jdm@636c30a

This comment has been minimized.

Copy link
Contributor

bors-servo replied Sep 11, 2013

merging jdm/servo/gccrash = 636c30a into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Sep 11, 2013

jdm/servo/gccrash = 636c30a merged ok, testing candidate = 2372a84

This comment has been minimized.

Copy link
Contributor

bors-servo replied Sep 11, 2013

fast-forwarding master to auto = 2372a84

bors-servo pushed a commit that referenced this pull request Sep 11, 2013
@bors-servo bors-servo merged commit 636c30a into servo:master Sep 11, 2013
1 check passed
1 check passed
default all tests passed
@DavidBruant

This comment has been minimized.

You may want to take a look at this bug and its patch
Should I open an issue?

This comment has been minimized.

Copy link
Owner Author

jdm replied Sep 13, 2013

Yes please!

This comment has been minimized.

Copy link

DavidBruant replied Sep 13, 2013

Sort of made an umbrella issue servo#934

ChrisParis pushed a commit to ChrisParis/servo that referenced this pull request Sep 7, 2014
Improve cleanup for websockets unload tests
@jdm jdm deleted the jdm:gccrash branch Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.